From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933368AbdABQZp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Jan 2017 11:25:45 -0500
Received: from mout.kundenserver.de ([212.227.126.187]:57183 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933055AbdABQZn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Jan 2017 11:25:43 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>, linux-crypto@vger.kernel.org,
        Jamie Iles <jamie@jamieiles.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration
Date: Mon, 02 Jan 2017 17:24:54 +0100
Message-ID: <2972455.z8LBYOSBAA@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <ab87e239-6623-764b-998d-3d8148a6adf1@osg.samsung.com>
References: <1483371482-4956-1-git-send-email-javier@osg.samsung.com> <2761495.aqgObxUbGB@wuerfel> <ab87e239-6623-764b-998d-3d8148a6adf1@osg.samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:+w4ZzF7iACW37Q+OZTFSwYEyZDYYR0i8Ei06NwNwgNc0MEwELBn
 CaaIQPDlKq7ryN2/UGK1ogs3G7LN5pG8+Z2eCD/8RyTz/VWl/IWpiqQp4GC8ZkRz03OCp8e
 jlwOwlOJbGjp29LZMtexv+33HWjamp1mBMRPwfrB8jP/2hbr3sdsCVDqtYVMupO40Oi8u1P
 FzJfRpKsDIcD8msgqK7JA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:IA3aCE5RhUk=:Turc/YlZzSmDLTXJfi9Wuv
 ZLpB8bgSpgspwj8wQq2eYP/5/HOJVCodu3B/JxIFizAlgr2pg3zwTF/rdjFxXZqI51OZwPeDj
 u/h7S094uUiXhi4Nv8owNtPaq04KXP9O02fnjKg4PHQl98k9I00NRAoytPYoPPBxuvWBvUpsO
 TpXyVMW2rU0P6GHT+ocpg7lG0IQ+7k9dDt1SSkwWRL+NL5crnIuVWRQwCmKUI7q/5G4bphi6+
 So1KNRhgtR1DimiWarSfl1MIFLI8oCdV6R+YhrujQyn8c8irUROYoh3d/oQb8LtOedY0xy5m0
 GpPn8E9jIMlezngD7zlRudSNghIV/LqQz4GKU5xkwi/t9O1sZhwpN1uv46j7TNY3Qh5t58rD7
 hELFI9vGx1QAupYbMLGWHnmy4ePeHKEL2V3yL7KVFa647J7hZQFfSqUIedhJ4NhgrdlQi99NZ
 Xu9yvqf01aP1oeD4V8YcqDzI48YU6j8hA29hl7banj3OhNuThqBkYu8XeUJZbDsTMG5520rde
 nP0/IlLcNkn+TebrU70m0tKeIe7WYiN5i9+DfhmJiGd1xGT8WL+kHFePgmYjrPDehqjmJZsL7
 DVxISdgNkEQOm53mtSkWPSahtCzGokOsdBNQkpxn/aY/8aVGorP8TL+KM/tgwuJKsgmAUP9Bf
 6yuobTSuzxVFkwQseOZoTnZECkUvA1su8PPLaTxgwx4zPQoBD8YWBlTo2Qfbw4wVmpyQAupdA
 k6o8jb2gOX9GDap3
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, January 2, 2017 1:13:24 PM CET Javier Martinez Canillas wrote:
> Hello Arnd,
> 
> On 01/02/2017 01:05 PM, Arnd Bergmann wrote:
> > On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote:
> >> If the driver is built as a module, autoload won't work because the module
> >> alias information is not filled. So user-space can't match the registered
> >> device with the corresponding module if the device isn't registered via OF.
> >>
> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> > 
> > I think we can just remove the table, as the platform only supports
> > booting through DT anyway.
> > 
> 
> Agreed. I should had checked if mach-picoxcell was DT-only indeed.
> 
> Should I also make the driver to depend on OF and remove the #ifdefery then?

I don't think we need a dependency, the #ifdef checks in there were needed
only to make the driver smaller if OF is disabled and it should still build
fine if someone tries to compile it for CONFIG_COMPILE_TEST without
CONFIG_OF.

If we remove the platform ID, we can however also remove the 
spacc_is_compatible() function and just call of_device_is_compatible()
in its place.

	Arnd