From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <r-gunasekaran@ti.com>,
<srk@ti.com>, <s-vadapalli@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file
Date: Tue, 12 Sep 2023 10:06:20 +0530 [thread overview]
Message-ID: <29739e31-a217-0fc2-fabf-30bd4f50c5b6@ti.com> (raw)
In-Reply-To: <340bb897-d735-fabc-a031-8e4ebcfe79fa@ti.com>
On 12/09/23 09:31, Siddharth Vadapalli wrote:
> Rob,
>
> Thank you for reviewing the patch.
>
> On 11/09/23 22:26, Rob Herring wrote:
...
>> Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.
>
> Sure, I will place it above the k3-j721s2-evm.dtb line.
>
>>
>>> dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
>>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
>>
>> I think dropping these will cause them to not get installed (by
>> dtbs_install). Presumably you want them.
>
> I will undo the above deletions in the v2 patch.
I have addressed the feedback and have posted the v2 patch at:
https://lore.kernel.org/r/20230912043308.20629-1-s-vadapalli@ti.com/
>
>>
>>> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>>>
>>> # Boards with J784s4 SoC
>>> dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
>>> --
>>> 2.34.1
>>>
>
--
Regards,
Siddharth.
prev parent reply other threads:[~2023-09-12 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 5:21 Siddharth Vadapalli
2023-09-11 16:56 ` Rob Herring
2023-09-12 4:01 ` Siddharth Vadapalli
2023-09-12 4:36 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29739e31-a217-0fc2-fabf-30bd4f50c5b6@ti.com \
--to=s-vadapalli@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=robh@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®