From: Yongbang Shi <shiyongbang@huawei.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: <xinliang.liu@linaro.org>, <tiantao6@hisilicon.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<kong.kongxinwei@hisilicon.com>, <liangjian010@huawei.com>,
<chenjianmin@huawei.com>, <lidongming5@huawei.com>,
<libaihan@huawei.com>, <shenjian15@huawei.com>,
<shaojijie@huawei.com>, <jani.nikula@linux.intel.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<shiyongbang@huawei.com>
Subject: Re: [PATCH v2 drm-dp 08/10] drm/hisilicon/hibmc: fix no showing when no connectors connected
Date: Mon, 30 Jun 2025 21:16:09 +0800 [thread overview]
Message-ID: <297f550b-8561-4ab9-ab7b-b7b47078803d@huawei.com> (raw)
In-Reply-To: <d3d23wf72e66e2lyj3jqsmajuskx5zbqok33o2sx3wrd3nipje@wavrn6adtbtx>
> On Fri, Jun 20, 2025 at 05:31:02PM +0800, Yongbang Shi wrote:
>> From: Baihan Li <libaihan@huawei.com>
>>
>> Our chip support KVM over IP feature, so hibmc driver need to support
>> displaying without any connectors plugged in. Deleting the detect_ctx()
>> of VGA to make it connected when no connector is detected.
> I think, there is more than that. Please see how AST driver handles the
> same issue. I think you need something similar.
Okay, thanks for your advice!
>> Fixes: 4c962bc929f1 ("drm/hisilicon/hibmc: Add vga connector detect functions")
>> Signed-off-by: Baihan Li <libaihan@huawei.com>
>> Signed-off-by: Yongbang Shi <shiyongbang@huawei.com>
>> ---
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
>> index 841e81f47b68..953474d04b5c 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
>> @@ -60,7 +60,6 @@ static void hibmc_connector_destroy(struct drm_connector *connector)
>> static const struct drm_connector_helper_funcs
>> hibmc_connector_helper_funcs = {
>> .get_modes = hibmc_connector_get_modes,
>> - .detect_ctx = drm_connector_helper_detect_from_ddc,
>> };
>>
>> static const struct drm_connector_funcs hibmc_connector_funcs = {
>> --
>> 2.33.0
>>
next prev parent reply other threads:[~2025-06-30 13:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 9:30 [PATCH v2 drm-dp 00/10] Fix hibmc driver bugs Yongbang Shi
2025-06-20 9:30 ` [PATCH v2 drm-dp 01/10] drm/hisilicon/hibmc: fix the i2c device resource leak when vdac init failed Yongbang Shi
2025-06-28 16:04 ` Dmitry Baryshkov
2025-06-20 9:30 ` [PATCH v2 drm-dp 02/10] drm/hisilicon/hibmc: fix dp probabilistical detect errors after HPD irq Yongbang Shi
2025-06-20 9:30 ` [PATCH v2 drm-dp 03/10] drm/hisilicon/hibmc: fix irq_request()'s irq name variable is local Yongbang Shi
2025-06-28 16:32 ` Dmitry Baryshkov
2025-06-20 9:30 ` [PATCH v2 drm-dp 04/10] drm/hisilicon/hibmc: fix the hibmc loaded failed bug Yongbang Shi
2025-06-28 17:02 ` Dmitry Baryshkov
2025-06-20 9:30 ` [PATCH v2 drm-dp 05/10] drm/hisilicon/hibmc: fix rare monitors cannot display problem Yongbang Shi
2025-06-20 9:31 ` [PATCH v2 drm-dp 06/10] drm/hisilicon/hibmc: add dp mode valid check Yongbang Shi
2025-06-28 17:04 ` Dmitry Baryshkov
2025-06-30 13:09 ` Yongbang Shi
2025-06-20 9:31 ` [PATCH v2 drm-dp 07/10] drm/hisilicon/hibmc: fix dp and vga cannot show together Yongbang Shi
2025-06-28 17:06 ` Dmitry Baryshkov
2025-06-30 13:15 ` Yongbang Shi
2025-06-20 9:31 ` [PATCH v2 drm-dp 08/10] drm/hisilicon/hibmc: fix no showing when no connectors connected Yongbang Shi
2025-06-28 17:08 ` Dmitry Baryshkov
2025-06-30 13:16 ` Yongbang Shi [this message]
2025-06-20 9:31 ` [PATCH v2 drm-dp 09/10] drm/hisilicon/hibmc: fix no showing problem with loading hibmc manually Yongbang Shi
2025-06-28 17:08 ` Dmitry Baryshkov
2025-06-20 9:31 ` [PATCH v2 drm-dp 10/10] drm/hisilicon/hibmc: adapting modification for the former commit Yongbang Shi
2025-06-28 17:09 ` Dmitry Baryshkov
2025-06-27 8:34 ` [PATCH v2 drm-dp 00/10] Fix hibmc driver bugs Yongbang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=297f550b-8561-4ab9-ab7b-b7b47078803d@huawei.com \
--to=shiyongbang@huawei.com \
--cc=airlied@gmail.com \
--cc=chenjianmin@huawei.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liangjian010@huawei.com \
--cc=libaihan@huawei.com \
--cc=lidongming5@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®