From: Jackie Dong <xy-jackie@139.com>
To: David Cemin <dcemin@nvidia.com>
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, W_Armin@gmx.de,
mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com,
ikepanhc@gmail.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, ldemarchi@nvidia.com
Subject: Re: [RFC PATCH 2/3] platform: lenovo: add WMI hotkeys driver
Date: Thu, 19 Nov 2026 20:12:07 +0800 [thread overview]
Message-ID: <29824d258033bd712497e2e1e0f9612bf98325fb.camel@139.com> (raw)
In-Reply-To: <20261119022922.3090399-1-dcemin@nvidia.com>
On Wed, 2026-11-18 at 18:29 -0800, David Cemin wrote:
> Hi Jackie,
>
> Thanks for the review and the Reviewed-by on patch 1.
>
> On merging wmi-hotkeys.c with wmi-hotkey-utilities.c: I kept them
> separate because they are different interfaces. wmi-hotkey-
> utilities.c
> drives the method GUID (microphone mute LED, Fn lock state), while
> wmi-hotkeys.c owns the event GUIDs and only turns events into input
> reports; the notifier chain is how the two sides meet, and ideapad-
> laptop
> uses it. If the maintainers prefer a single file the merge is
> mechanical
> and I am happy to do it in v3; otherwise I would keep the method and
> event
> sides apart, as the other Lenovo WMI drivers do.
>
> v2 is out as 20261119022719.3089229-1-dcemin@nvidia.com and includes
> your tag.
>
> Thanks,
> David
Hi David,
I agree that wmi-hotkeys.c and wmi-hotkey-utilities.c are different
interfaces. But I stick on my point that the two file names are
similar and easy to confuse for developers and maintainer.
I suggest another file name should be a solution, such as wmi-hotkeys-
switches.c, wmi-FnKey-event-report.c, FYR.
Regards,
Jackie
next prev parent reply other threads:[~2026-11-19 12:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 22:27 [RFC PATCH 0/3] platform: lenovo: architecture independent home for the Lenovo WMI drivers David Cemin
2026-11-13 22:27 ` [RFC PATCH 1/3] platform: lenovo: move the architecture independent WMI drivers out of x86 David Cemin
2026-11-15 21:50 ` Mark Pearson
2026-11-16 4:42 ` David Cemin
2026-11-16 16:59 ` Mark Pearson
2026-11-17 2:27 ` Jackie Dong
2026-11-13 22:27 ` [RFC PATCH 2/3] platform: lenovo: add WMI hotkeys driver David Cemin
2026-11-15 16:12 ` Armin Wolf
2026-11-16 4:42 ` David Cemin
2026-11-17 1:39 ` Armin Wolf
2026-11-16 10:55 ` Marco Giunta
2026-11-17 3:27 ` Jackie Dong
2026-11-19 2:29 ` David Cemin
2026-11-19 12:12 ` Jackie Dong [this message]
2026-11-13 22:27 ` [RFC PATCH 3/3] platform/x86: ideapad-laptop: do not bind the WMI event devices without the VPC David Cemin
2026-11-15 15:33 ` [RFC PATCH 0/3] platform: lenovo: architecture independent home for the Lenovo WMI drivers Hans de Goede
2026-11-15 16:02 ` Armin Wolf
2026-11-15 18:02 ` Hans de Goede
2026-11-15 20:10 ` Hans de Goede
2026-11-15 20:12 ` Hans de Goede
2026-11-15 21:48 ` Mark Pearson
2026-11-16 4:42 ` David Cemin
2026-11-19 2:27 ` [PATCH v2 " David Cemin
2026-11-19 2:27 ` [PATCH v2 1/3] platform: lenovo: move the architecture independent WMI drivers out of x86 David Cemin
2026-11-19 12:49 ` Rong Zhang
2026-11-19 2:27 ` [PATCH v2 2/3] platform: lenovo: add WMI hotkeys driver David Cemin
2026-11-19 6:10 ` Armin Wolf
2026-11-19 12:56 ` Rong Zhang
2026-11-19 2:27 ` [PATCH v2 3/3] platform/x86: ideapad-laptop: consume the Fn key events from the " David Cemin
2026-11-19 6:16 ` Armin Wolf
2026-11-19 13:00 ` Rong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29824d258033bd712497e2e1e0f9612bf98325fb.camel@139.com \
--to=xy-jackie@139.com \
--cc=W_Armin@gmx.de \
--cc=dcemin@nvidia.com \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=ldemarchi@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®