From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: dhowells@redhat.com, khoroshilov@ispras.ru, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RXRPC]: do not unlock unheld spinlock in rxrpc_connect_exclusive()
Date: Wed, 18 Dec 2013 16:10:55 +0000 [thread overview]
Message-ID: <29861.1387383055@warthog.procyon.org.uk> (raw)
In-Reply-To: <20131217.151656.2218064732946772466.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Date: Sat, 14 Dec 2013 02:56:09 +0400
>
> > + _net("CONNECT EXCL old %d on TRANS %d",
> > + conn->debug_id, conn->trans->debug_id);
>
> Please do not add more of these ad-hoc kernel log tracing entries.
Why not? They're useful for debugging and they give me more control than
plain printk().
I presume you want all the debugging statements in net/rxrpc/ changing to
something else - but what?
David
prev parent reply other threads:[~2013-12-18 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 22:56 Alexey Khoroshilov
2013-12-17 20:16 ` David Miller
2013-12-18 16:08 ` David Howells
2013-12-18 16:10 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29861.1387383055@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®