From: Yuchen Zhang <zhangyuchen.lcr@bytedance.com>
To: minyard@acm.org
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, qi.zheng@linux.dev
Subject: Re: [PATCH 1/3] ipmi: fix msg stack when IPMI is disconnected
Date: Sun, 9 Oct 2022 08:53:21 +0800 [thread overview]
Message-ID: <298867dd-01d9-cd61-cdaa-95bbaf2dd2e4@bytedance.com> (raw)
In-Reply-To: <Y0FjriRusk0H4Fxp@minyard.net>
Ok, I will send v2 today.
On 10/8/22 7:49 PM, Corey Minyard wrote:
> On Sat, Oct 08, 2022 at 09:36:16AM +0800, Yuchen Zhang wrote:
>>> Also, the following is in start_kcs_transaction():
>>>
>>> if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
>>> dev_warn(kcs->io->dev, "KCS in invalid state %d\n", kcs->state);
>>> return IPMI_NOT_IN_MY_STATE_ERR;
>>> }
>>>
>>> You probably need to remove the (kcs->state != KCS_HOSED) part of this
>>> now. Would you agree?
>>>
>>> -corey
>>>
>> I agree. KCS_HOSED state should be an invalid state.
>
> Can you make this change, run a quick test, and re-submit this one
> patch? With that, I can include this.
>
> Thanks,
>
> -corey
--
Thanks,
Zhang Yuchen
next prev parent reply other threads:[~2022-10-09 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 9:26 [PATCH 0/3] ipmi: fix ipmi memleak and unload bug Zhang Yuchen
2022-10-07 9:26 ` [PATCH 1/3] ipmi: fix msg stack when IPMI is disconnected Zhang Yuchen
2022-10-07 19:43 ` Corey Minyard
2022-10-08 1:36 ` Yuchen Zhang
2022-10-08 11:49 ` Corey Minyard
2022-10-09 0:53 ` Yuchen Zhang [this message]
2022-10-07 9:26 ` [PATCH 2/3] ipmi: fix long wait in unload when IPMI disconnect Zhang Yuchen
2022-10-07 19:48 ` Corey Minyard
2022-10-07 9:26 ` [PATCH 3/3] ipmi: fix memleak when unload ipmi driver Zhang Yuchen
2022-10-07 19:51 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=298867dd-01d9-cd61-cdaa-95bbaf2dd2e4@bytedance.com \
--to=zhangyuchen.lcr@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=qi.zheng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome