From: Adrian Hunter <adrian.hunter@intel.com>
To: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>,
quic_asutoshd@quicinc.com, ulf.hansson@linaro.org,
agross@kernel.org, bjorn.andersson@linaro.org,
linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: stummala@codeaurora.org, vbadigan@codeaurora.org,
quic_rampraka@quicinc.com, quic_pragalla@quicinc.com,
sartgarg@codeaurora.org, nitirawa@codeaurora.org,
sayalil@codeaurora.org, Liangliang Lu <luliang@codeaurora.org>,
"Bao D . Nguyen" <nguyenb@codeaurora.org>
Subject: Re: [PATCH V3 3/4] mmc: core: Capture eMMC and SD card errors
Date: Fri, 21 Jan 2022 10:20:09 +0200 [thread overview]
Message-ID: <2989ff51-374e-3ab5-f8d4-19e0a1873a66@intel.com> (raw)
In-Reply-To: <1642699582-14785-4-git-send-email-quic_c_sbhanu@quicinc.com>
On 20/01/2022 19:26, Shaik Sajida Bhanu wrote:
> Add changes to capture eMMC and SD card errors.
> This is useful for debug and testing.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Signed-off-by: Liangliang Lu <luliang@codeaurora.org>
> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
> Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com>
> ---
> drivers/mmc/core/core.c | 8 ++++++++
> drivers/mmc/core/queue.c | 3 +++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 368f104..c586d69 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -2242,6 +2242,14 @@ void mmc_rescan(struct work_struct *work)
> if (freqs[i] <= host->f_min)
> break;
> }
> +
> + /*
> + * Ignore the command timeout errors observed during
> + * the card init as those are excepted.
> + */
> +
Please remove blank line here.
> + if (host && host->err_stats_enabled)
The condition is not needed.
> + host->err_stats[MMC_ERR_CMD_TIMEOUT] = 0;
Please put this after successful call to mmc_rescan_try_freq
> mmc_release_host(host);
>
> out:
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index c69b2d9..7dc9dfb 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -100,6 +100,9 @@ static enum blk_eh_timer_return mmc_cqe_timed_out(struct request *req)
> enum mmc_issue_type issue_type = mmc_issue_type(mq, req);
> bool recovery_needed = false;
>
> + if (host->err_stats_enabled)
> + mmc_debugfs_err_stats_inc(host, MMC_ERR_CMDQ_REQ_TIMEOUT);
Doesn't this get covered by the drivers. It seems like this should not be needed.
> +
> switch (issue_type) {
> case MMC_ISSUE_ASYNC:
> case MMC_ISSUE_DCMD:
>
next prev parent reply other threads:[~2022-01-21 8:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 17:26 [PATCH V3 0/4] mmc: add error statistics for eMMC and SD card Shaik Sajida Bhanu
2022-01-20 17:26 ` [PATCH V3 1/4] mmc: sdhci: Capture eMMC and SD card errors Shaik Sajida Bhanu
2022-01-21 7:08 ` Adrian Hunter
2022-01-25 18:17 ` Sajida Bhanu (Temp)
2022-02-01 13:58 ` Adrian Hunter
2022-02-08 19:04 ` Sajida Bhanu (Temp) (QUIC)
2022-02-11 5:51 ` Adrian Hunter
2022-02-15 12:28 ` Sajida Bhanu (Temp)
2022-02-15 16:59 ` Bjorn Andersson
2022-02-16 7:34 ` Sajida Bhanu (Temp) (QUIC)
2022-01-20 17:26 ` [PATCH V3 2/4] mmc: debugfs: Add debug fs entry for mmc driver Shaik Sajida Bhanu
2022-01-21 7:10 ` Adrian Hunter
2022-01-25 18:19 ` Sajida Bhanu (Temp) (QUIC)
2022-02-01 13:59 ` Adrian Hunter
2022-01-20 17:26 ` [PATCH V3 3/4] mmc: core: Capture eMMC and SD card errors Shaik Sajida Bhanu
2022-01-21 8:20 ` Adrian Hunter [this message]
2022-01-25 18:40 ` Sajida Bhanu (Temp) (QUIC)
2022-01-20 17:26 ` [PATCH V3 4/4] mmc: cqhci: " Shaik Sajida Bhanu
2022-01-21 8:22 ` Adrian Hunter
2022-01-25 18:41 ` Sajida Bhanu (Temp) (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2989ff51-374e-3ab5-f8d4-19e0a1873a66@intel.com \
--to=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=luliang@codeaurora.org \
--cc=nguyenb@codeaurora.org \
--cc=nitirawa@codeaurora.org \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_c_sbhanu@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=sartgarg@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®