From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B1D369983 for ; Sat, 31 Jan 2026 19:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769887289; cv=none; b=Vqa8jg7qY8xXKZ2LYnoAg/jDec0hhrMqn6+Tx8xyt29htZCVrKgMBuUldBooRJHwyyUIDYyabQNEu9k1/0/IcSUPgx4E1TLHu9J9ZgCV7LH6pXk0OTgIpfxR9YUJU4RoNqVqyKqwSUdC9Sxvu+lv/9AK+lSVHS9IJIPTlV2sHU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769887289; c=relaxed/simple; bh=twjPrjnXgWq9BihAJShadALT5mdKLYOhW7LJw/KQQdQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XVFiS5AGsol0E99xFwcthSsZLb+JhBspF8VMYCg0MUCeyZdQ8GfLo9iFAwDejrHjNk2Svv4GXqDDUZ40o/ut+dlKJnnBQd4JQXGsaEwxcd56MXHMVwFQtVa/KW24aTyAHUO0wvdnM9W1Ht3INgfMTjNLAocRrSG7/y6VqxTko3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Fg+kbTJI; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Fg+kbTJI" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7d18f80b5c2so2775163a34.3 for ; Sat, 31 Jan 2026 11:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769887285; x=1770492085; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mg351UXmtMA/dk9xyDkawr0wqd4z8SkQhGWvqh3DLjE=; b=Fg+kbTJIWRhY6a0ETUNCakF38HWBeKfFPa2FTmbYmqoQUrPVrampgZniEbzttaGpEn UdzXG/ic8eDt+RAwlXm2WtqfcSDzhg+2JARv7x54ysdyOTmEMjrtSiCzWy5eUOP5UKCr 3Unp4O77hg0bkc+EbFbTXH4muW0L3Xnvkg+ztW6nN5SdjohXw8oF7dBmBTkEObbcJ1ep oBchdxdcPPa95HpuIuvxiaPJhRvwueDi4a0sunGqESZnxLkt/SKYuSDx0ZpziAv9VrPI x25X33Sr1SnsH4YCNkxRhkpg2jA+eCjNJPH8yBXFcXTTkSQsH84zUG74zTbsVuYWpKbN BFGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769887285; x=1770492085; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mg351UXmtMA/dk9xyDkawr0wqd4z8SkQhGWvqh3DLjE=; b=udBjQQ2ll8DtzDy1KJD27u2JyzTQFbKguO0BrWjCG10jmr/QcFnKz6SqMokWPXMHjT RTd2jwIGkyPpSgcVfBClkN/+scR7Ao48fWIVTod4EjJUKQfyGNmn/IJ9hjFWdtN9Mnw/ ZJqp0yTSaaev4ioTZZGeJeReaJCYRy5DYTmGbbR9ZeZn4ICfYFIe9wSBbSpyF+86+gar J6hvA9ODhaXFir03lGmi+/x57cyurmaQwLzabsMMxem+HZXXzhVyF5W7Xxjxadi+I1/5 YABNP30xuQi7gG+rm9gICeNcjgVuTtBHbY24VMJfO250NQg+kr2uiIiYg1id7PTkiC9B JKVQ== X-Forwarded-Encrypted: i=1; AJvYcCXt09s1RTqoGbLn+elmJc7qBnqUIvJPjeYdUlxLkyb9t0yGDktogBzV+pmrjHHxNCyhzbLHdVwpdqZDKMc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxgic4ssx6qqq1rGE1J3AVBQHWyPpSL8xPW/9O/R5YQpFqmL4n8 t6xVQVJGwCYiw3tu3+nPScdyPg6/C27VQCcbVS9sWEGeNBJs62O78H60kdYLEVOnJDA= X-Gm-Gg: AZuq6aL97fnw68PYbDYpHhRYwKiEqAzrLl+5Kz+pbhE+Y+hJAwHJpbeSmdeRxvgpXWt mcCzmXtiudbmomFa6Y6sC5fwbFHFZOT5dB+hbriL1mZ9MnvIlEdvvqGv2hPqDEw2MlGi9qDssbc bOuJAI2ci3tc/ChU9otj5Ft/KouHwG16Lz07b5b5LIHCxEkfPxp+4yfNUfSbAkEcPAIMGToimqX QFg/4ehJsgxvPsiTLSSSY763uqO4Jql35pP0VozzErJG8rLUpOzjyX6bIPxkwROBvt9vPcwXqEp xJcbGsIMKK5n7snliKiCsorT9STOSyxMGFscJGS2tcC4isEhNqBsI01MvF6omJDjC4T9KDES/gs CTOnQhkvwkLXFDsaA5TFhBF2nvBvHeKNxDEw60UHQHjRj9hLZvfJPqswC+Afr4NgD8KFsN5lgTL uGUbYHKm05YHajcdG1VygnTidotjnppS4r/dijvIHNGDHM1TdXyE6Yjp681pl4 X-Received: by 2002:a05:6830:82eb:b0:7c7:4f2:e15d with SMTP id 46e09a7af769-7d1a52d199cmr4698200a34.16.1769887284722; Sat, 31 Jan 2026 11:21:24 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:c7ef:51f2:4f7a:6cd7? ([2600:8803:e7e4:500:c7ef:51f2:4f7a:6cd7]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d18c69e63esm7677530a34.11.2026.01.31.11.21.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jan 2026 11:21:24 -0800 (PST) Message-ID: <298d1c61-e6c9-4aa8-8f94-82f218ac37b5@baylibre.com> Date: Sat, 31 Jan 2026 13:21:23 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers To: Harshit Mogalapalli , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Andrew Ijano , "open list:IIO SUBSYSTEM AND DRIVERS" , open list Cc: kernel-janitors@vger.kernel.org, Andy Shevchenko References: <20260130214323.236389-1-harshit.m.mogalapalli@oracle.com> <20260130214323.236389-3-harshit.m.mogalapalli@oracle.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260130214323.236389-3-harshit.m.mogalapalli@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/30/26 3:43 PM, Harshit Mogalapalli wrote: > Convert the threaded IRQ registration to devm_request_threaded_irq() so > that the probe and remove paths can drop manual freeing of irqs. > > No functionality change. > ... > @@ -1484,23 +1483,17 @@ static int sca3000_probe(struct spi_device *spi) > } > ret = sca3000_clean_setup(st); > if (ret) > - goto error_free_irq; > + return ret; > > ret = sca3000_print_rev(indio_dev); > if (ret) > - goto error_free_irq; > + return ret; > > ret = iio_device_register(indio_dev); > if (ret) > - goto error_free_irq; > + return ret; > > return 0; This can `return iio_device_register();` directly now.