mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Jiale Yao <yaojiale02@163.com>
Cc: platform-driver-x86@vger.kernel.org, corentin.chary@gmail.com,
	 luke@ljones.dev, denis.benato@linux.dev, jprvita@gmail.com,
	 Hans de Goede <hansg@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wireless:  Check ACPI_COMPANION() against NULL
Date: Mon, 13 Jul 2026 14:18:47 +0300 (EEST)	[thread overview]
Message-ID: <298e177e-9f10-1d5f-0e42-01a7f98453f8@linux.intel.com> (raw)
In-Reply-To: <20260712151743.3314169-1-yaojiale02@163.com>

On Sun, 12 Jul 2026, Jiale Yao wrote:

You've an extra space in the subject in all of these.

Also, please send similar patches for different drivers in a series so 
it's easier for me to apply them in a one go.

--
 i.

> Every platform driver can be forced to match a device that doesn't match
> its list of device IDs because of device_match_driver_override(), so
> platform drivers that rely on the existence of a device's ACPI companion
> object need to verify its presence.
> 
> Accordingly, add a requisite ACPI_COMPANION() check against NULL to the
> asus-wireless driver.
> 
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---
>  drivers/platform/x86/asus-wireless.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 2b494bf3cba8..54052bda9061 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -132,6 +132,9 @@ static int asus_wireless_probe(struct platform_device *pdev)
>  	const struct acpi_device_id *id;
>  	int err;
>  
> +	if (!adev)
> +		return -ENODEV;
> +
>  	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
>  	if (!data)
>  		return -ENOMEM;
> 

  reply	other threads:[~2026-07-13 11:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 15:17 Jiale Yao
2026-07-13 11:18 ` Ilpo Järvinen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-06  2:49 Linmao Li
2026-07-06 17:29 ` Wysocki, Rafael J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=298e177e-9f10-1d5f-0e42-01a7f98453f8@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=corentin.chary@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=hansg@kernel.org \
    --cc=jprvita@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yaojiale02@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®