From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A35813148A7 for ; Tue, 2 Dec 2025 13:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764680617; cv=none; b=AOjpbT/2Hy9EQzZ75/3H0PPj9vOC9mW34I5q055GaLF+uXpbS7GZxuZbBJHUufXP5nmpq6nCe07+2fdpIiq5ZcOO2LYVrXCf+xJztZ0DltGRqH+/y8jMcT95Amh5C6/45jPjdfSfG5ymKuAYBpHqDEI4JnpyUqJ4tfhWL0FhlOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764680617; c=relaxed/simple; bh=KdKmDoBxn/rPOKUCTHhKFuAtVgA9Ufb6RRmosnME1ac=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AUWEr2PXoK2NvBWb2Zirs6dcocEyklsgy77KWjGeO5uzKZG7JgXQQTo0euoGyM48RmrwiJ7spNbk/cdPtU2Q+0Umk4+HamW/kW+dq+moWMYpHhaztPTHpnvwSSaoE6HJkkXJMxVsqCFqX16adXpJIA1BPatkFX4FPmRnndchK5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IbjlIVHE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LYE0WAs1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IbjlIVHE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LYE0WAs1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764680614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ey6wtgDcQ116K7LfiiQ+bxQUIrUIywSYa0E8sps1NXc=; b=IbjlIVHEEexRMBkBbTpwQzIPXVd4O/mbz2eLxYGcfYMLPWUV/GQZ4kfdjVGXYpSZDdNKgV GssSGDWFgYFDfRZFUVKGKI4O4nO0JYpLDrJIHUrbB+BM0t83U/ShQPl2LvsRAzOxqFSO8/ 5rENaXxNrmkurEqn71zqqRlRWL8+qnE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-AcrUjls2P7i2wn2mUKGzhw-1; Tue, 02 Dec 2025 08:03:33 -0500 X-MC-Unique: AcrUjls2P7i2wn2mUKGzhw-1 X-Mimecast-MFC-AGG-ID: AcrUjls2P7i2wn2mUKGzhw_1764680611 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso36656435e9.2 for ; Tue, 02 Dec 2025 05:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764680611; x=1765285411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ey6wtgDcQ116K7LfiiQ+bxQUIrUIywSYa0E8sps1NXc=; b=LYE0WAs1DDSDkJyXgmhQfyA1qlDf3KHTgPYaOd+TkDuf3XF7BGA55qwbd2eACxcQQB tAQi1UXKhpmDgCXAR6dM+ItCNt1axhyZ0ZJVWm6+dxn23te5DjAYqKaUHCEFdNflXGhP f2OKAr9kWfc23uxxOQmUg3XYaD4ymIm2PIyjby2YGLHwtnpttFF/1eFfAF0QPWiFrHTx MLk28/TGSG3w3MRvGuJKsaVDYNcDtCc0SVepE9/mz8k7JAsOD6lT4+s0Po0XchwUupZ9 nVOSoJjMhvxpyKHOLPrp2WsMtvoPmAe7TRKngdYtga4pAbL75TB1IgBFolK1LzS8LE1N Ohvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764680611; x=1765285411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ey6wtgDcQ116K7LfiiQ+bxQUIrUIywSYa0E8sps1NXc=; b=voyQyocqjqJBlTjxR6sPW8nDW5UFaLm64b00YWPomZLYc+XQYvrhofVNgZFf6/e7i7 lxSTRhmM6iIGpCCmj8wvqE1ErZpa57Oc6WkbFQKdkxzoSN59I6sJ7z4LTaf+BS/a9f7m 6ojVykU9Z+ymVGpVP9Kej2imAOiCPw0JFzcJjTeP0ElPs0T1Osx2fcHWEcbAzDGIfplO spAdYBTGAteS4QVWVs1iqqSfgJhc9Q1KsorS5zP7xVVeZhIr7/wNE1nv9bFWrcr97JBw wv3MnN7lNc/WUcD2piBfT/qS4VA5WGNhIZSJFrosLRTE/kF/CMsUm0vpIvwKHAO87kBn 5NdQ== X-Forwarded-Encrypted: i=1; AJvYcCVCwUSzFBGNNSAvjfE1e0e1pUAwCUeIlpykv3OEx1pEeCNxEAZgtIiD31P6rTaGfan2rSvPwWnRQRFib/o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy51siCKYlX4CDEaRSPVSLim/teP9CgzGjzByCB7Dp61U4GZPLl CZ6nja0lmZ2RrDbkh4vRCsnBQwZ3QtZ+5FZERnRB0LWyZ3tQMTCO5EN88d1hBlUjwqJoKnuX7mh 0n7QEW7CbHJjB7Iz6w3ZlwLB4f57HXbwGkGtebEt4/QSGu26BpHaJejmGknxp7KkOQg== X-Gm-Gg: ASbGncuXPLAmCy0/XlYg4R6k3VJzSX7i6LVLmvJAL2uj2FuN9XHkkVwnco6Zl0CbXlZ KLjBxATuNl4ft0EHO2Q7tqtz0cvJ+4uGt8Yx1tp6S2WW3xjaZdY4ZGFXeqNd6E1aNiWPJX5nhVx +EJMKc1Q0E7g4utgeqShzkcJrksrDnXF7XmdFq2vnZ8LN5DA2z7s7bEkU4P70p3wyB40xwFcqHu U33ICDp8Cq/SZSStLLoX6Bbh4a+Po53JaEahJULbU8PNffgYQfpVbLOAxl1jwM4v1xS0ZOcRPvq 5/jC99NOEMnazx3AjfJ6NpUgEZWYwpYoqDq2yAxmQQsKWiNhkKOesDSSblJngsye/MBFDN5F2eR w1T556WG0tp/srw== X-Received: by 2002:a05:600c:35d2:b0:46e:4e6d:79f4 with SMTP id 5b1f17b1804b1-47904ae214emr355760315e9.15.1764680611247; Tue, 02 Dec 2025 05:03:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmafT5DyC4RoGwnfp5MmrgkftnBIjDmLkHPcVwpalWPTKpHlhk1u8H7c9dIZ7UKqeyugJgdw== X-Received: by 2002:a05:600c:35d2:b0:46e:4e6d:79f4 with SMTP id 5b1f17b1804b1-47904ae214emr355760035e9.15.1764680610815; Tue, 02 Dec 2025 05:03:30 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.136]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790add60e2sm355758785e9.6.2025.12.02.05.03.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 05:03:30 -0800 (PST) Message-ID: <298e982d-7796-4e46-ad1d-a7f57c573f35@redhat.com> Date: Tue, 2 Dec 2025 14:03:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v21 02/14] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values To: Maxime Chevallier , davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau , Tariq Toukan References: <20251129082228.454678-1-maxime.chevallier@bootlin.com> <20251129082228.454678-3-maxime.chevallier@bootlin.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251129082228.454678-3-maxime.chevallier@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/29/25 9:22 AM, Maxime Chevallier wrote: > @@ -298,138 +321,149 @@ static_assert(ARRAY_SIZE(link_mode_names) == __ETHTOOL_LINK_MODE_MASK_NBITS); > .speed = SPEED_UNKNOWN, \ > .lanes = 0, \ > .duplex = DUPLEX_UNKNOWN, \ > + .mediums = BIT(ETHTOOL_LINK_MEDIUM_NONE), \ > } > > const struct link_mode_info link_mode_params[] = { > - __DEFINE_LINK_MODE_PARAMS(10, T, Half), > - __DEFINE_LINK_MODE_PARAMS(10, T, Full), > - __DEFINE_LINK_MODE_PARAMS(100, T, Half), > - __DEFINE_LINK_MODE_PARAMS(100, T, Full), > - __DEFINE_LINK_MODE_PARAMS(1000, T, Half), > - __DEFINE_LINK_MODE_PARAMS(1000, T, Full), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(10, T, 2, 4, Half, T), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(10, T, 2, 4, Full, T), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(100, T, 2, 4, Half, T), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(100, T, 2, 4, Full, T), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(1000, T, 4, 4, Half, T), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(1000, T, 4, 4, Full, T), > __DEFINE_SPECIAL_MODE_PARAMS(Autoneg), > __DEFINE_SPECIAL_MODE_PARAMS(TP), > __DEFINE_SPECIAL_MODE_PARAMS(AUI), > __DEFINE_SPECIAL_MODE_PARAMS(MII), > __DEFINE_SPECIAL_MODE_PARAMS(FIBRE), > __DEFINE_SPECIAL_MODE_PARAMS(BNC), > - __DEFINE_LINK_MODE_PARAMS(10000, T, Full), > + __DEFINE_LINK_MODE_PARAMS_PAIRS(10000, T, 4, 4, Full, T), > __DEFINE_SPECIAL_MODE_PARAMS(Pause), > __DEFINE_SPECIAL_MODE_PARAMS(Asym_Pause), > - __DEFINE_LINK_MODE_PARAMS(2500, X, Full), > + __DEFINE_LINK_MODE_PARAMS_MEDIUMS(2500, X, Full, > + __MED(C) | __MED(S) | __MED(L)), > __DEFINE_SPECIAL_MODE_PARAMS(Backplane), > - __DEFINE_LINK_MODE_PARAMS(1000, KX, Full), > - __DEFINE_LINK_MODE_PARAMS(10000, KX4, Full), > - __DEFINE_LINK_MODE_PARAMS(10000, KR, Full), > + __DEFINE_LINK_MODE_PARAMS(1000, KX, Full, K), > + __DEFINE_LINK_MODE_PARAMS(10000, KX4, Full, K), > + __DEFINE_LINK_MODE_PARAMS(10000, KR, Full, K), > [ETHTOOL_LINK_MODE_10000baseR_FEC_BIT] = { > .speed = SPEED_10000, > .lanes = 1, > .duplex = DUPLEX_FULL, The AI review points that medium is not initialized here: https://netdev-ai.bots.linux.dev/ai-review.html?id=437cd013-c6a6-49e1-bec1-de4869930c7a#patch-1 Is that intentional? It should deserve at least an explanation in the commit message. Somewhat related, AI raised on the first patch the same question raised on a previous iteration, and I assumed you considered that valid, according to: https://lore.kernel.org/netdev/f753719e-2370-401d-a001-821bdd5ee838@bootlin.com/ Otherwise I think some wording in the commit message explaining why the AI feedback is incorrect would be useful. /P