From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752282AbaFLTyy (ORCPT ); Thu, 12 Jun 2014 15:54:54 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:57665 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751836AbaFLTyw (ORCPT ); Thu, 12 Jun 2014 15:54:52 -0400 From: "Rafael J. Wysocki" To: Kees Cook Cc: linux-kernel@vger.kernel.org, Randy Dunlap , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Len Brown , Pavel Machek , Wei Yongjun , linux-doc@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] hibernate: create one-way disable mode Date: Thu, 12 Jun 2014 22:12:19 +0200 Message-ID: <2990889.du3yZFtply@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1402602419-27934-2-git-send-email-keescook@chromium.org> References: <1402602419-27934-1-git-send-email-keescook@chromium.org> <1402602419-27934-2-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 12, 2014 12:46:58 PM Kees Cook wrote: > To support using kernel features that are not compatible with hibernation, > this creates a "disabled" hibernation state so that hibernation selection > can be a boot-time choice instead of only a compile-time choice. Well, hibernation_mode is only to determine how to turn the system off after saving the image. It doesn't say how the whole hibernation is supposed to work (or not). Please just extend the hibernate= command line argument to cover this. Rafael