From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 930E1C43461 for ; Mon, 10 May 2021 13:50:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71BD861584 for ; Mon, 10 May 2021 13:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238129AbhEJNt1 convert rfc822-to-8bit (ORCPT ); Mon, 10 May 2021 09:49:27 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:43517 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233973AbhEJNkT (ORCPT ); Mon, 10 May 2021 09:40:19 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-27-bBycmq91M5C3TfJHA3srvw-1; Mon, 10 May 2021 14:38:53 +0100 X-MC-Unique: bBycmq91M5C3TfJHA3srvw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 14:38:50 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.015; Mon, 10 May 2021 14:38:49 +0100 From: David Laight To: 'Fabio Aiuto' , "gregkh@linuxfoundation.org" CC: "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones Thread-Topic: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones Thread-Index: AQHXRaBE0Vec4dAP60OcHOZcBIBf86rcuAwA Date: Mon, 10 May 2021 13:38:49 +0000 Message-ID: <29938747c82e4cf1837be5f1cdb803b7@AcuMS.aculab.com> References: In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > replace private CRC-32 routines with in-kernel ones. Have you verified that they compute the same CRC? There are all sorts of subtle reasons why the outputs can differ. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)