From: Ying Xue <ying.xue@windriver.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Jon Maloy <jon.maloy@ericsson.com>,
"David S. Miller" <davem@davemloft.net>,
<tipc-discussion@lists.sourceforge.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Qian Zhang <zhangqian-c@360.cn>
Subject: Re: [PATCH net] tipc: check minimum bearer MTU
Date: Thu, 1 Dec 2016 18:07:47 +0800 [thread overview]
Message-ID: <2993fe74-a4d3-55ea-c600-ade0f0ee3a02@windriver.com> (raw)
In-Reply-To: <20161130132333.GD19119@unicorn.suse.cz>
>>
>> For UDP bearer, it seems insufficient for us to check MTU size only
>> when UDP bearer is enabled. Meanwhile, we should update MTU size for
>> UDP bearer with Path MTU discovery protocol once MTU size is changed
>> after bearer is enabled.
>
> I should admit I'm not that familiar with tipc. Do you mean updating
> b->mtu in response to PMTU updates of the route used for ub->ubsock?
Yes.
> The way I understand it, it would be certainly useful but it's not
> directly related to the security issue this patch addresses as if there
> are no updates, b->mtu cannot get too low and there is no risk of
> a buffer overflow. In other words, reflecting PMTU updates is something
> that can be IMHO left for later.
>
Agreed.
Regards,
Ying
> Michal Kubecek
>
next prev parent reply other threads:[~2016-12-01 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 9:57 Michal Kubecek
2016-11-30 10:24 ` Michal Kubecek
2016-12-01 0:05 ` Ben Hutchings
2016-11-30 10:28 ` Ying Xue
2016-11-30 13:23 ` Michal Kubecek
2016-12-01 10:07 ` Ying Xue [this message]
2016-12-01 7:21 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2993fe74-a4d3-55ea-c600-ade0f0ee3a02@windriver.com \
--to=ying.xue@windriver.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=zhangqian-c@360.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome