From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3FAC433F5 for ; Mon, 31 Jan 2022 17:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381060AbiAaRiA (ORCPT ); Mon, 31 Jan 2022 12:38:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381036AbiAaRh5 (ORCPT ); Mon, 31 Jan 2022 12:37:57 -0500 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC7B7C06173B for ; Mon, 31 Jan 2022 09:37:57 -0800 (PST) Received: by mail-il1-x12a.google.com with SMTP id i2so3322470ilm.12 for ; Mon, 31 Jan 2022 09:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8XiEhEIc6GPrOy61yWxlOIFlYNHT1dKB1NGb7FtAFv8=; b=eitccCFFfue7+J/VoBFC3XgyotyS9xyGKLRYGs9u4JIUeo3e//pzWH29TGLwyiIGaJ Sc/xy9hvdCtOSNr/C5zarL0GDTP95d5T2WgrPuwsBdHh8d7ytjkp3FqbJQQ1B+KniG2g u9FweIeFiyHtgS01zJCVMG2eorfA6gIqWNi3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8XiEhEIc6GPrOy61yWxlOIFlYNHT1dKB1NGb7FtAFv8=; b=JyQYL0xeEQJcvIR8Jz/evwtuUrUqbb66y7dcdP1gVRoll7iihUqDmNm3qNeRn9pFCT HObmYV3UZYpckWLsO/BoUe0l3FC5/VfHtqVXrgL3L3z0VxZr7liVdQdYXhBEdC/2jgMV 6+nBRVot6AjxNthdN+n4m+vFpwR71GkTYmQD9qWB/jxb4BHKjJvI9w5O3bYW2ECo1oac Jfw7RjNBzlbnPJWhYkhLHhT805IUuR/mMUqlMRqnvBwEnDBFZXwubv1aTRXkSAiIrEWz B7a1+boLp2XxOYh5UX+I7cV+GD4Pihz9FSkHvOUDG3luDcZ2DJ9BB4U4eSFfBmtNS78Y /fLw== X-Gm-Message-State: AOAM532eFljX0hnmByjM/vnuvvJ5vGWzsHTQiGsxpuDrHhJMzl3l5Kiu 5Ef+C8D5TvSPquhqpQkiAtJ2fOc3N2MxLw== X-Google-Smtp-Source: ABdhPJy82tBGgtocPF6fYHvtMkpmZ07MAXznuTPlai5ZQ11Xm+VEykni4kt+G/4+lrWjvPjWaohedQ== X-Received: by 2002:a05:6e02:152c:: with SMTP id i12mr12746996ilu.215.1643650677138; Mon, 31 Jan 2022 09:37:57 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id z5sm19459022ioq.47.2022.01.31.09.37.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 09:37:56 -0800 (PST) Subject: Re: [PATCH v4] kselftest: Fix vdso_test_abi return status To: Vincenzo Frascino , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shuah Khan , Andy Lutomirski , Thomas Gleixner , Cristian Marussi , Shuah Khan References: <20220131113405.25977-1-vincenzo.frascino@arm.com> From: Shuah Khan Message-ID: <299a9d32-ec50-029b-b8c7-b89aff6331a4@linuxfoundation.org> Date: Mon, 31 Jan 2022 10:37:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220131113405.25977-1-vincenzo.frascino@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/22 4:34 AM, Vincenzo Frascino wrote: > vdso_test_abi contains a batch of tests that verify the validity of the > vDSO ABI. > > When a vDSO symbol is not found the relevant test is skipped reporting > KSFT_SKIP. All the tests return values are then added in a single > variable which is checked to verify failures. This approach can have > side effects which result in reporting the wrong kselftest exit status. > > Fix vdso_test_abi verifying the return code of each test separately. > > Cc: Shuah Khan > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Reported-by: Cristian Marussi > Signed-off-by: Vincenzo Frascino > --- > tools/testing/selftests/vDSO/vdso_test_abi.c | 135 +++++++++---------- > 1 file changed, 62 insertions(+), 73 deletions(-) > Thank you. Applied to linux-kselftest fixes for rc3 thanks, -- Shuah