From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E0A1C9B95 for ; Thu, 31 Oct 2024 18:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730398151; cv=none; b=P/znO6qCzz9UrEkIDEXwVeifjzANrrIWI/5R3E+9P0vHjVjzW7loag6clOM67t9Hld+EOE3z6yvOkCMqvfM50lTgPqIP7gv+TCvGghZarn2N94eT0VRk/abLtXQqvPiqh+lBW8H5I5Jbdie9bDzfi1eceBJHWd0bgk2A5M51YJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730398151; c=relaxed/simple; bh=pnbU4m92rARoAQneTzD5Jf7lxArdrciMF5RdRrZAC90=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pp3liKhrMORlV55vmIkPDRXZw5rxQsUqxy7ytpb2pGqgKsW40xpA2VC59pv2FDqGEnacEx+e07gaysW5pWBJl1fFJGGQRInUSR+T12iz6WqX4j/8Ji/TF6IOA66QNcM709UyOmEPCf7/ncsdCNM5bxAjpxQJqzT4y1wAnG1U3Ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fAaJ5huc; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fAaJ5huc" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4315839a7c9so10678675e9.3 for ; Thu, 31 Oct 2024 11:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730398147; x=1731002947; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ww423lfHl3RJq60oXMLHUaPgCkzs8qQvv8BPeWX9FNU=; b=fAaJ5hucJLzb9BJ0BTeSBPSlS5JAPc1/GQ/iYI2MQTLAz54G3icBNlpUwSXt3trkOl LofHTRleJfPRqvxrGi2vOVvWEh7phBLqlq4CbFhs/qIT97IAk9ZOLtDEZhSGCnzj7LCC wygsc9SBMsnXEIRxByN0J2yVs50/MXi/1UM3W2epC2gaUGXPCzMWCXUkuSLKcG2qNxcX Fq4M9f1jq8siskRcrFfK0sf7e1Q1FAyR1FAATkrPNurKcnpD0j2ZW9L1DfN6wWYD+AqB AqjWH1ObbQseKhLERSS0PC6eDEaIMhWx9HWJNabqbr7ZZL/M3ds8piULfrY14rHx35o9 aoJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730398147; x=1731002947; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ww423lfHl3RJq60oXMLHUaPgCkzs8qQvv8BPeWX9FNU=; b=p9/nL4pyRUSNj0ctz2RQoMyX7Mkr79lnZ+KYJWLTny/HevCjuqFoX/0OCQCIS88IZ3 LqqmT4Z3Mn5rGLvLyO5lT15YIpQVwhNK0Ct3DpaH9JmfhJKc1E+a7MOIniY1enq5zBwk mK5kBlgkmkCMAPh4/xYv8ok++Cva6EJ2EZhD7ZfX/UoANXBoa4mZtAbqqCSn510cGm4u dWnosNRiXln9RggKmVBHzxs0hChK5XRUuQZ5McTW1w0S4iAOpmPTdq8OSWJA/Jb2aInv R7di18g3skROCbG1PnmGwtAVSN8/vmUHQUmcj0INdiZZf406PdOxU8OV7vuWcJXYa9j+ scAw== X-Forwarded-Encrypted: i=1; AJvYcCVJa5jsomfnqZGR0Z5siNYyPLbRVt2d6XoOMYGla95cfHwdbXV//L9qdrMiqaDg45inX3k07a4Lv+IXcT0=@vger.kernel.org X-Gm-Message-State: AOJu0YxTDu61BShMrddtWfJ47qAIw1qoeGcWkSNQ4gCTu9t0sbzp2+wk eccYw7YqLIkeW0kAY2iSJM62FDJk7NuWCfthJA4blLgE/ncayoLESAVxGmuzCWU= X-Google-Smtp-Source: AGHT+IGUTRQz69TQsAsuaTFQLcFekqsDLfAz6CitU1HfJ7lLbNV0dp4jvalOgtIpFWbq8+MW+JPV4w== X-Received: by 2002:a05:600c:4f4a:b0:42c:b9c8:2bb0 with SMTP id 5b1f17b1804b1-4319ac70637mr167227885e9.4.1730398146724; Thu, 31 Oct 2024 11:09:06 -0700 (PDT) Received: from [192.168.0.17] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10d473bsm2833645f8f.35.2024.10.31.11.09.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 11:09:05 -0700 (PDT) Message-ID: <299befa1-63f9-4fff-8d5a-0753ae620c11@linaro.org> Date: Thu, 31 Oct 2024 18:09:04 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] arm64: dts: qcom: sc7280: Add support for camss To: Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20241030105347.2117034-1-quic_vikramsa@quicinc.com> <20241030105347.2117034-6-quic_vikramsa@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241030105347.2117034-6-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/10/2024 10:53, Vikram Sharma wrote: > Add changes to support the camera subsystem on the SC7280. > > Signed-off-by: Suresh Vankadara > Signed-off-by: Trishansh Bhardwaj > Signed-off-by: Vikram Sharma > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 175 +++++++++++++++++++++++++++ > 1 file changed, 175 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 55db1c83ef55..690051708dec 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -4426,6 +4426,181 @@ cci1_i2c1: i2c-bus@1 { > }; > }; > > + camss: camss@acaf000 { > + compatible = "qcom,sc7280-camss"; > + > + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, Order of declaration of the nodes needs to conform to Documentation/devicetree/bindings/dts-coding-style.rst i.e. reg should come first after compatible --- bod