From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09376C55179 for ; Thu, 29 Oct 2020 01:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD81420790 for ; Thu, 29 Oct 2020 01:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730974AbgJ2BB5 (ORCPT ); Wed, 28 Oct 2020 21:01:57 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6569 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731502AbgJ1WRW (ORCPT ); Wed, 28 Oct 2020 18:17:22 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CLfXp16fvzhcmf; Wed, 28 Oct 2020 14:58:02 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 28 Oct 2020 14:57:56 +0800 Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value To: Robin Hsu , , , CC: References: <20201026094000.1500425-1-robinhsu@google.com> From: Chao Yu Message-ID: <299c9027-e137-83ff-b2ba-8af07144a488@huawei.com> Date: Wed, 28 Oct 2020 14:57:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201026094000.1500425-1-robinhsu@google.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote: > 'ret' should not have been used here: otherwise, it would be wrongly used > as the error code and then be returned from main(). > > Signed-off-by: Robin Hsu BTW, how about changing 'ret = EXIT_ERR_CODE' to 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though. Reviewed-by: Chao Yu Thanks,