From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 027B9342C98 for ; Fri, 17 Jul 2026 13:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784293364; cv=none; b=OOR9UvB8vfL8OEY6D+yZXqz3G4qmdWJCer2sP5nR3LEukPaRzz75IAVlLVBGaBQ/Gu6ZFSAQk340utt+WXimcu9a10QeaiPS7qOazuwNX3zG7d9bt7FQfVj+MMA5XHjvKpKOW9RSGxtZ1HZxsZw5iyJAEmc1WqOAnt9xpDJ5X4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784293364; c=relaxed/simple; bh=en62BqSQ78MnTW57X3OeM1J6ogv8xbeDaz/hsDGB30c=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=I0nDy2+xlyk+BbZAZezdDcrdOlbAq5OeGCLLNjpKe+Vz78jBCskIT61TpHiLqt9ZuiftxRKr97K7xT7y9a0lF1yAYim3xTO5+dj+zsD84FCKTzuxu0rXA733Tr444cEDaTfuoEBmqLsIdpN1IJRvAS1ZCv8w6tl5flOFN0zlOGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZuqUPutU; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZuqUPutU" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784293360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pbrcad0JFlGI9q3Xx6aWcT9RKHrQcyE9kOYfZFc6BkM=; b=ZuqUPutU70Vp1I4HGehC67GOdHBwnBNEg7dTGbWdHh9XQoiFqNsm24smjGGdj/z+wukY9n FbMkOsIyvUVWdZrQ9IOikMxKZ5ZHWQWgsTysG3T6mQkPbangAufeDGtnRv9POMME2V+lMc 6d1TYb0bxXK4rtYqmw3owxIJgeGPugU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH 3/3] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260717113300.214717-4-ridong.chen@linux.dev> Date: Fri, 17 Jul 2026 21:02:09 +0800 Cc: Andrew Morton , Johannes Weiner , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Zhongkun He , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Content-Transfer-Encoding: 7bit Message-Id: <29BDCD72-66E7-4C62-95E5-0754AEB91A93@linux.dev> References: <20260717113300.214717-1-ridong.chen@linux.dev> <20260717113300.214717-4-ridong.chen@linux.dev> To: Ridong X-Migadu-Flow: FLOW_OUT > On Jul 17, 2026, at 19:33, Ridong wrote: > > From: Ridong Chen > > Commit 57972c78e678 ("mm/vmscan: make __node_reclaim() more generic") > moved the scan_control construction out to the callers and passed the > struct in by pointer. After that change every use of the gfp mask inside > __node_reclaim() goes through sc->gfp_mask, leaving the gfp_mask parameter > unused. Just remove the dead parameter and update the callers accordingly. > No functional change. > > Signed-off-by: Ridong Chen Reviewed-by: Muchun Song