From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.4 required=3.0 tests=BUG6152_INVALID_DATE_TZ_ABSURD,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INVALID_DATE_TZ_ABSURD,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B98C43331 for ; Mon, 11 Nov 2019 10:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CA9D206BB for ; Mon, 11 Nov 2019 10:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573467315; bh=gm+O7SDvmRrd2N9uRuvDOnFtNkovJrlzrws1Xw8+/SM=; h=To:Subject:Date:From:Cc:In-Reply-To:References:List-ID:From; b=EX7EWjC7sJaHkrH9byPSTjpOfVZExKkHqLV7+qzEXdaS+jf4y5XpZPiqcJZp0e6Xe cwF2S8oC3ExEVn6Cfn5dlcukfZecYbnsn1OoDsmNIRyZ7Qk8wRdFam2JBwNgmX4M2m 78+QJXitB64uk/VHmA80a2tDD3/azH1awmD+N6AQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfKKKPO (ORCPT ); Mon, 11 Nov 2019 05:15:14 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:50993 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfKKKPN (ORCPT ); Mon, 11 Nov 2019 05:15:13 -0500 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1iU6it-0007sA-5c; Mon, 11 Nov 2019 11:15:03 +0100 To: Lokesh Vutla Subject: Re: [PATCH] irqchip/ti-sci-inta: Use =?UTF-8?Q?ERR=5FCAST=20inlin?= =?UTF-8?Q?ed=20function=20instead=20of=20ERR=5FPTR=28PTR=5FERR=28=2E=2E?= =?UTF-8?Q?=2E=29=29?= X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Nov 2019 11:24:24 +0109 From: Marc Zyngier Cc: Markus Elfring , , Jason Cooper , Nishanth Menon , Santosh Shilimkar , Tero Kristo , Thomas Gleixner , LKML , In-Reply-To: <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com> References: <776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de> <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com> Message-ID: <29a69991ec7726d133e54a2891159e86@www.loen.fr> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: lokeshvutla@ti.com, markus.elfring@web.de, linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net, nm@ti.com, ssantosh@kernel.org, t-kristo@ti.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-11-11 04:45, Lokesh Vutla wrote: > On 05/11/19 5:00 PM, Markus Elfring wrote: >> From: Markus Elfring >> Date: Tue, 5 Nov 2019 12:19:39 +0100 >> >> A coccicheck run provided information like the following. >> >> drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be >> used >> with vint_desc. >> >> Generated by: scripts/coccinelle/api/err_cast.cocci >> >> Thus adjust the exception handling in one if branch. >> >> Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 >> ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") > > Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt > Aggregator driver") I fundamentally disagree with the "Fixes:" tag. This isn't a fix, just a minor readability improvement. Flagging things as "Fixes:" ends up triggering all kind of unnecessary backports to -stable. > With this: > > Reviewed-by: Lokesh Vutla I'll otherwise take this patch in -next. Thanks, M. -- Jazz is not dead. It just smells funny...