mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Scott Guo <scottzhguo@tencent.com>,
	Phillip Lougher <phillip@squashfs.org.uk>
Cc: Scott Guo <scott_gzh@163.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] squashfs: Avoid mem leak in squashfs_fill_super()
Date: Tue, 12 Aug 2025 17:57:44 +0200	[thread overview]
Message-ID: <29a87213-8a56-439a-98d3-377d067dda9d@web.de> (raw)
In-Reply-To: <20250812030403.517269-1-scott_gzh@163.com>

> If sb_min_blocksize() returns 0, -EINVAL was returned without freeing
> sb->s_fs_info, causing mem leak.

                         memory?


> Fix it by calling and checking result of sb_min_blocksize() before
> kzalloc.

         () call?

Regards,
Markus

      reply	other threads:[~2025-08-12 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12  3:04 scott_gzh
2025-08-12 15:57 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29a87213-8a56-439a-98d3-377d067dda9d@web.de \
    --to=markus.elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@squashfs.org.uk \
    --cc=scott_gzh@163.com \
    --cc=scottzhguo@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®