mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Andrew Lunn <andrew@lunn.ch>, Harini Katakam <harinik@xilinx.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Florian Fainelli <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read
Date: Mon, 11 Mar 2019 07:45:22 +0100	[thread overview]
Message-ID: <29a9b36a-eeae-c768-cd71-c10294f011a1@xilinx.com> (raw)
In-Reply-To: <20190309161912.GD9000@lunn.ch>

Hi,

On 09. 03. 19 17:19, Andrew Lunn wrote:
>> Related to this, I have a query on how the DT node for gmii2rgmii should look.
>> One of the users of gmii2rgmii is Cadence macb driver. In Xilinx tree, we use
>> this piece of code to register this mdiobus:
>> + mdio_np = of_get_child_by_name(np, "mdio");
>> + if (mdio_np) {
>> + of_node_put(mdio_np);
>> + err = of_mdiobus_register(bp->mii_bus, mdio_np);
>> + if (err)
>> + goto err_out_unregister_bus;
>>
>> And the DT node looks like this:
>> ethernet {
>>     phy-mode = "gmii";
>>     phy-handle = <&extphy>;
>>
>>     mdio {
>>         extphy {
>>             reg = <x>;
>>         };
>>         gmii_to_rgmii{
>>             compatible = "xlnx,gmii-to-rgmii-1.0";
>>             phy-handle = <&extphy>;
>>             reg = <x>;
>>         };
>>     };
>> };
> 
> Hi Harini
> 
> You have this setup:
>   
> MAC <==> GMII2RGMII <==> RGMII_PHY
> 
> So you want the MAC phy-handle to point to the gmii_to_rgmii 'PHY'.

That means that MAC should talk to GMII2RGMII bridge as normall talks to
RGMII_PHY and then GMII2RGMII bridge should talk to RGMII_PHY.

Anyway good to read it because that's exactly how we have done it in u-boot.

Thanks,
Michal

      parent reply	other threads:[~2019-03-11  6:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 16:32 Paul Kocialkowski
2019-02-15 17:02 ` Andrew Lunn
2019-02-15 17:38 ` Florian Fainelli
2019-02-15 18:34   ` Paul Kocialkowski
2019-02-15 18:53     ` Florian Fainelli
2019-02-19  9:56       ` Paul Kocialkowski
2019-02-19 17:25         ` Andrew Lunn
2019-02-20  6:58           ` Michal Simek
2019-02-21 10:24             ` Paul Kocialkowski
2019-02-21 11:03               ` Michal Simek
2019-02-27  8:43                 ` Michal Simek
2019-02-27  9:05                   ` Harini Katakam
2019-02-28  7:33                     ` Harini Katakam
2019-03-09 12:09                       ` Harini Katakam
2019-03-09 16:19                         ` Andrew Lunn
2019-03-11  6:04                           ` Harini Katakam
2019-03-11 12:27                             ` Harini Katakam
2019-03-11 12:51                               ` Michal Simek
2019-03-11  6:45                           ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29a9b36a-eeae-c768-cd71-c10294f011a1@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=harinik@xilinx.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®