From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D628152532 for ; Mon, 3 Mar 2025 07:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740986054; cv=none; b=KRV2/DMRuvRMOBkdsfWjTr72BJ2StqBOlJHiLHTS/E8YRWp3Xf0EBNfS7G988niBJNoYQiBKU88pB8pBAFzGTKEe5kkD3fAqDuQCUf+T7HFVrNTbG7Fqi8OHs8ltPSCG6Co17caVxKyDUPlB6PEfoqZW7BHi1Fc9cFJlONlLmE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740986054; c=relaxed/simple; bh=Hln+g5OCHrAMOq/+1aDVAlOsgByEM+bWM9zySDltuR4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MHYtVqA2LgE+n98yhdCz4a6qsOjVvQnaagXueQcIqqfsYbDHFydHgyPGrUWlpgM5E3/dMvyEV/mi7dF9IG4l2SFK9RxFvlFdsMKXy0c+Q8t/F8f+GUSr3hkrYS4ZsrvRgPLq9Qz8EWruCJgFAbEDhmueaMo10mhGpnYnosf9rqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lo5jZC3i; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lo5jZC3i" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-abec8b750ebso710486466b.0 for ; Sun, 02 Mar 2025 23:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740986050; x=1741590850; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8RROaO6yARYWUmuYiLttBRg0vezrYJsF0zsoMASJ+Y0=; b=lo5jZC3iAcg9TiASEN+02v8tjNCnIVO65YHcjQRfQveoHu178Vz4pycEF2VX+IMf1N qVjKOMdtBeG1S5LjTzJrESdeRo8xG0RwJnTyUMV5NV3DfAMSh3hUdACUGlxF7uuqzvuV q1Mtm38cTmfNA3U0vbvUKUONHRBoOI+RDB4J73PWf+7ikbFfIAZVliX3S3ZJh/uBpSfQ csU6x/97ZIR9KzXPZ6JMwqWZjeT8NFz6VqvWxH2fplDnXAOIEVAtR3CtiAiscZUsdZ9n zwSBDpFAFoxZ3XJYliPKS/+AjC0Fs1eROjFVnqa1BAmBdok7E+48ekfPKMlPham2XFXA aRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740986050; x=1741590850; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8RROaO6yARYWUmuYiLttBRg0vezrYJsF0zsoMASJ+Y0=; b=FjN6aqlc+dLJY3AFYj+gy6X+7xUXaKezIjE5lp/KxMGDQcbHcUDPeStmsPdzdC+1C5 r+/D9Jo5v20TEj5S3GZG3hcxev53jhFXEtjPKhyF+WD85j2CYIDyvLilMNUUZ6eCCUKR AKgUGaFP/NOlJL3Z0cqBJf+gIMv9LNjhEszWcoLL8pSZ3Ew9Bh5lhch3nu2ptwIKg9nb TORC3mADJ8LuVbk8g+n+M29IwnJh8QmWMqvln+mxjjP2Zofq+7NtmAJh5T2pOLxK7lZP u5FpETOBOxdX5KaPVy4sSp/Omaf4z/PSfd8DwIw8qlujwuDU7Clbp4q26ptj0yfYb6EP qt0g== X-Forwarded-Encrypted: i=1; AJvYcCXCivOsy5fmtnmsrBuj+R63gHuORVvBYIJWd1TsGMXEH7EYuDntmgoMpX4BOPkSfpdQ/nZFawscWUgKd+g=@vger.kernel.org X-Gm-Message-State: AOJu0YyA9Bid7zxr9dQq3Ywprnu5AxuHRemkXMgHXYJexGK5Hl2gIFc0 FsO0o4rM7re4ZI9Kx4XlC5932+ecDfL32hS1MEGt0jH5JAWyFyTo3QglI20/hyE= X-Gm-Gg: ASbGncuc9P/LGLam76AaY402qZSXKJWwKByWXBr346f5XG5rnOnl5UL1wf5THlT2ShX +1zbu1mB+C0QJ4JYAvXaKDE/pa0/+U/UB7GjpW2BXZ72wZiu6UgnlJVOWHMoul6VThAt3bzdaTP FsD2fXdBnoJV9SRO+nVdFbsQXdNprBWtYvjK0bhkZrYl3mOHCp8VZVc1uT8yblc3ecrIRkj0pc2 3W0jVjKaALE2kSKgSYfrKa7Pf+w5+1DX8crjmlXkiWlSZjhmCReciJmYzV2p67ah+kvrYPmLeg1 w9vIB031fWTtZtJJluY6BKUQwon4rNLT703BUXW9AWw57W0AmA== X-Google-Smtp-Source: AGHT+IEny668UimPZ3R6dx4axvviTs297S1IJ5VK/kkx2SxfpDGI4c5Rl/7By42IdqNYV74cMm4sFA== X-Received: by 2002:a17:907:980e:b0:ab7:b250:aaa with SMTP id a640c23a62f3a-abf2682f996mr1554838466b.54.1740986050266; Sun, 02 Mar 2025 23:14:10 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ac1dd6fd870sm60633966b.70.2025.03.02.23.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Mar 2025 23:14:09 -0800 (PST) Date: Mon, 3 Mar 2025 10:14:06 +0300 From: Dan Carpenter To: Dmitry Baryshkov Cc: Markus Elfring , kernel-janitors@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Archit Taneja , Daniel Vetter , David Airlie , Jeykumar Sankaran , Jordan Crouse , Marijn Suijten , Rob Clark , Sean Paul , Simona Vetter , Vinod Koul , cocci@inria.fr, LKML Subject: Re: [PATCH RESEND] drm/msm/dpu: Delete a variable initialisation before a null pointer check in two functions Message-ID: <29b32b0d-312d-4848-9e26-9e5e76e527a7@stanley.mountain> References: <40c60719-4bfe-b1a4-ead7-724b84637f55@web.de> <1a11455f-ab57-dce0-1677-6beb8492a257@web.de> <13566308-9a80-e4aa-f64e-978c02b1406d@web.de> <54c30a69-71cf-4582-9086-50eb0d39f273@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 03, 2025 at 01:01:40AM +0200, Dmitry Baryshkov wrote: > On Sun, Mar 02, 2025 at 09:56:00PM +0100, Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 11 Apr 2023 18:24:24 +0200 > > > > The address of a data structure member was determined before > > a corresponding null pointer check in the implementation of > > the functions “dpu_hw_pp_enable_te” and “dpu_hw_pp_get_vsync_info”. > > > > Thus avoid the risk for undefined behaviour by removing extra > > initialisations for the variable “c” (also because it was already > > reassigned with the same value behind this pointer check). There is no undefined behavior here. > > > > This issue was detected by using the Coccinelle software. > > Please don't send resends and/or new iterations in response to your > previous patchsets. Otherwise they have a pretty high chance to be > ignored by the maintainers. Use a fresh git-send-email command to send > new patchset. > > > > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Remove the Fixes tag. This patch is fine as a clean up. > > Signed-off-by: Markus Elfring regards, dan carpenter