mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>, Ulf Hansson <ulfh@kernel.org>
Cc: shawn.lin@rock-chips.com, Jaehoon Chung <jh80.chung@samsung.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops
Date: Wed, 15 Jul 2026 10:16:53 +0800	[thread overview]
Message-ID: <29b8489c-3a0b-4e9d-a6f6-0400e7d00103@rock-chips.com> (raw)
In-Reply-To: <20260710161254.569883-1-ben.dooks@codethink.co.uk>

在 2026/07/11 星期六 0:12, Ben Dooks 写道:
> The dw_mci_pmops is exported out of dw_mmc.c so move the declaration of
> ton dw_mmc.h from dw_mmc-pltfm.h to fix the following sparse warning:
> 
> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
> 

Sorry for late response, this looks good to me,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>


> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> v2:
>    - changed to moving the definition and re-worded commit
> ---
>   drivers/mmc/host/dw_mmc-pltfm.h | 1 -
>   drivers/mmc/host/dw_mmc.h       | 2 ++
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-pltfm.h b/drivers/mmc/host/dw_mmc-pltfm.h
> index ef1b05d484c3..f3193662abf1 100644
> --- a/drivers/mmc/host/dw_mmc-pltfm.h
> +++ b/drivers/mmc/host/dw_mmc-pltfm.h
> @@ -11,6 +11,5 @@
>   extern int dw_mci_pltfm_register(struct platform_device *pdev,
>   				const struct dw_mci_drv_data *drv_data);
>   extern void dw_mci_pltfm_remove(struct platform_device *pdev);
> -extern const struct dev_pm_ops dw_mci_pmops;
>   
>   #endif /* _DW_MMC_PLTFM_H_ */
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 9ffcd3946cff..38610c89d54a 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -19,6 +19,8 @@
>   #include <linux/interrupt.h>
>   #include <linux/workqueue.h>
>   
> +extern const struct dev_pm_ops dw_mci_pmops;
> +
>   enum dw_mci_state {
>   	STATE_IDLE = 0,
>   	STATE_SENDING_CMD,


      parent reply	other threads:[~2026-07-15  2:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 16:12 Ben Dooks
2026-07-13 11:25 ` Ulf Hansson
2026-07-15  2:16 ` Shawn Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29b8489c-3a0b-4e9d-a6f6-0400e7d00103@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®