From: Daniel Drake <dan@reactivated.net>
To: "Joerg Roedel (AMD)" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
nick.hollinghurst@raspberrypi.com, james.quinlan@broadcom.com,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v5 5/5] arm64: dts: broadcom: bcm2712: Add GPU IOMMU and IOMMU cache nodes
Date: Fri, 18 Sep 2026 22:06:43 +0100 [thread overview]
Message-ID: <29bf6c8a-1689-4fda-b605-c972e91d1c73@reactivated.net> (raw)
In-Reply-To: <20260909-bcm2712-iommu-submit-v5-5-2539c52b249e@reactivated.net>
On 09/09/2026 21:08, Daniel Drake wrote:
> Define the IOMMU and IOMMUC nodes for the Broadcom BCM2712 SoC found in
> the Raspberry Pi 5. Enable use of the IOMMU for the graphics/display
> block.
> @@ -667,6 +680,7 @@ v3d: gpu@1002000000 {
>
> vc4: gpu {
> compatible = "brcm,bcm2712-vc6";
> + iommus = <&iommu4>;
> };
>
> timer {
> @@ -701,5 +715,6 @@ hvs: hvs@107c580000 {
> interrupt-parent = <&disp_intr>;
> interrupts = <2>, <9>, <16>;
> interrupt-names = "ch0-eof", "ch1-eof", "ch2-eof";
> + iommus = <&iommu4>;
Found some issues here: the iommus property needs to be added to the
dt-bindings for this to be considered valid, and actually, it should not
be added to the vc4 node (that is just a virtual node), only the hvs node.
But that setup triggers a warning from the iommu layer because the
dma/iommu setup is established too late during vc4 device setup.
Working on it...
next prev parent reply other threads:[~2026-09-18 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 20:08 [PATCH v5 0/5] Add support for Broadcom BCM2712 IOMMU driver (Raspberry Pi 5) Daniel Drake
2026-09-09 20:08 ` [PATCH v5 1/5] iommu_pt: Fix test_pgsize_boundary() failure on narrow-OA formats Daniel Drake
2026-09-09 20:08 ` [PATCH v5 2/5] dt-bindings: iommu: Add Broadcom BCM2712 IOMMU Daniel Drake
2026-09-09 20:08 ` [PATCH v5 3/5] iommu/generic_pt: Add Broadcom BCM2712 page table format Daniel Drake
2026-09-09 20:08 ` [PATCH v5 4/5] iommu: Add Broadcom BCM2712 IOMMU driver Daniel Drake
2026-09-09 20:08 ` [PATCH v5 5/5] arm64: dts: broadcom: bcm2712: Add GPU IOMMU and IOMMU cache nodes Daniel Drake
2026-09-18 21:06 ` Daniel Drake [this message]
2026-09-24 10:41 ` Joerg Roedel (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29bf6c8a-1689-4fda-b605-c972e91d1c73@reactivated.net \
--to=dan@reactivated.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=iommu@lists.linux.dev \
--cc=james.quinlan@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nick.hollinghurst@raspberrypi.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®