From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755961AbeASOhi (ORCPT ); Fri, 19 Jan 2018 09:37:38 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35784 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755245AbeASOh2 (ORCPT ); Fri, 19 Jan 2018 09:37:28 -0500 X-Google-Smtp-Source: ACJfBovBUP86XPIP2nPWriZyMXUm24Z807iBRpbZB87awSD2/AlMOhvP4vPJ+K4qjiQrkcpXs/0rmA== Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs To: Roman Gushchin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Jakub Kicinski , Daniel Borkmann , Alexei Starovoitov References: <20180115191615.13911-1-guro@fb.com> <34c43a17-7832-413e-fea8-4ad0f80f1585@netronome.com> <20180119141739.GA22398@castle.DHCP.thefacebook.com> From: Quentin Monnet Message-ID: <29c01fd7-8f1e-91bf-0be6-a2b220e0e637@netronome.com> Date: Fri, 19 Jan 2018 14:37:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180119141739.GA22398@castle.DHCP.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-01-19 14:17 UTC+0000 ~ Roman Gushchin > On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote: [...] >> Looks good, thanks Roman! >> Would you mind updating the map names as well? It seems the >> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. > > Hello, Quentin! > > > Here is the patch. > > > Thanks! > > -- > > From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Fri, 19 Jan 2018 14:07:38 +0000 > Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps > > Add BPF_MAP_TYPE_CPUMAP map type to the list > of map type recognized by bpftool and define > corresponding text representation. > > Signed-off-by: Roman Gushchin > Cc: Quentin Monnet > Cc: Jakub Kicinski > Cc: Daniel Borkmann > Cc: Alexei Starovoitov > --- > tools/bpf/bpftool/map.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c > index a152c1a5c94c..f95fa67bb498 100644 > --- a/tools/bpf/bpftool/map.c > +++ b/tools/bpf/bpftool/map.c > @@ -66,6 +66,7 @@ static const char * const map_type_name[] = { > [BPF_MAP_TYPE_HASH_OF_MAPS] = "hash_of_maps", > [BPF_MAP_TYPE_DEVMAP] = "devmap", > [BPF_MAP_TYPE_SOCKMAP] = "sockmap", > + [BPF_MAP_TYPE_CPUMAP] = "cpumap", > }; > > static unsigned int get_possible_cpus(void) > Good, thank you! Acked-by: Quentin Monnet