mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	David Lechner <david@lechnology.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/sitronix: move tiny Sitronix drivers to their own subdir
Date: Mon, 5 May 2025 12:19:30 +0200	[thread overview]
Message-ID: <29c139fe-337d-4cd2-944b-8e26080a326f@suse.de> (raw)
In-Reply-To: <87r013wgoy.fsf@minerva.mail-host-address-is-not-set>

Hi Javier, Marcus

Am 05.05.25 um 11:27 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann@suse.de> writes:
>
> Hello Thomas,
>
>> Hi,
>>
>> there's one major issue here. You must not change the Kconfig symbols or
>> you'll break kernel updates for a lot of people. So those TINYDRM_* must
>> remain as is.
>>
> I disagree. The https://docs.kernel.org/admin-guide/abi.html document
> explictly states that Kconfig symbols are not an ABI, and userspace
> should not rely on these not changing over time.

To summarize our discussion on irc [1]: changing the symbols is ok, but 
we should make it compatible to ease the transition. To do so, the new 
Kconfig file can still contain the old Kconfig symbol and the new one 
defaults to it. Something like this:

config TINYDRM_ST7586
   tristate
   default n

config DRM_ST7586
   tristate "bla bla"
   ...
   default TINYDRM_ST7586

Doing 'make olddefconfig' or a similar make command sets the new symbol 
from the pre-existing one. After a few releases the old symbol can be 
removed.

Best regards
Thomas


[1] 
https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2025-05-05&show_html=true

>
>> Best regards
>> Thomas
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


  reply	other threads:[~2025-05-05 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03  8:13 Marcus Folkesson
2025-05-05  9:06 ` Thomas Zimmermann
2025-05-05  9:27   ` Javier Martinez Canillas
2025-05-05 10:19     ` Thomas Zimmermann [this message]
2025-05-05 11:00       ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29c139fe-337d-4cd2-944b-8e26080a326f@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=david@lechnology.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marcus.folkesson@gmail.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®