From: "Pierre Asselin" <pa@panix.com>
To: "Pierre Asselin" <pa@panix.com>
Cc: dri-devel@lists.freedesktop.org, "Pierre Asselin" <pa@panix.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] firmware/sysfb: Fix VESA format selection
Date: Thu, 20 Apr 2023 12:05:28 -0400 [thread overview]
Message-ID: <29c370c79a9775398bcd0f111196f677.squirrel@mail.panix.com> (raw)
In-Reply-To: <20230420155705.21463-1-pa@panix.com>
I went back to nested max3() after all as Thomas asked. My first cut
had casts in the innermost max3() and the code looked truly awful. I
decided that two casts are tolerable. I added a comment to explain
the casts.
Against clamp_t(u8,lfb_depth,1,32): the clamp_t() macro does no
typechecking; might as well just cast lfb_depth to u8, but that assumes
the value would fit (positively crazy if it doesn't, but still.)
Instead, I widen the other two args of the outer max3().
--PA
next prev parent reply other threads:[~2023-04-20 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 15:57 Pierre Asselin
2023-04-20 16:05 ` Pierre Asselin [this message]
2023-04-21 11:32 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-21 11:35 ` Thomas Zimmermann
2023-04-21 13:42 ` Pierre Asselin
2023-04-21 12:37 ` Thomas Zimmermann
2023-05-10 17:25 ` Pierre Asselin
2023-05-11 8:05 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29c370c79a9775398bcd0f111196f677.squirrel@mail.panix.com \
--to=pa@panix.com \
--cc=ardb@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®