From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbeEKQoe (ORCPT ); Fri, 11 May 2018 12:44:34 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:56510 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbeEKQob (ORCPT ); Fri, 11 May 2018 12:44:31 -0400 Subject: Re: [PATCH] selftests: memfd: split regular and hugetlbfs tests To: "Shuah Khan (Samsung OSG)" , akpm@linux-foundation.org Cc: marcandre.lureau@redhat.com, sj38.park@gmail.com, anders.roxell@linaro.org, lizhijian@cn.fujitsu.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180510201354.23930-1-shuah@kernel.org> From: Mike Kravetz Message-ID: <29c67a1f-179d-1003-ed51-94cebe0f48fd@oracle.com> Date: Fri, 11 May 2018 09:43:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180510201354.23930-1-shuah@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8890 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805110158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2018 01:13 PM, Shuah Khan (Samsung OSG) wrote: > Split normal memfd and hugetlbfs tests to improve the test reporting. > Remove run_fuse_test.sh and memfd_test from run_tests.sh and add them > to the Makefile. > > Add memfd_test to TEST_GEN_PROGS to be run separately. > Rename run_tests.sh to run_hugetlbfs_test.sh > Add run_fuse_test.sh and run_hugetlbfs_test.sh to TEST_PROGS > > The report for non-root run wth this change is: > > TAP version 13 > selftests: memfd: memfd_test > ======================================== > memfd: CREATE > memfd: BASIC > memfd: SEAL-WRITE > memfd: SEAL-SHRINK > memfd: SEAL-GROW > memfd: SEAL-RESIZE > memfd: SHARE-DUP > memfd: SHARE-MMAP > memfd: SHARE-OPEN > memfd: SHARE-FORK > memfd: SHARE-DUP (shared file-table) > memfd: SHARE-MMAP (shared file-table) > memfd: SHARE-OPEN (shared file-table) > memfd: SHARE-FORK (shared file-table) > memfd: DONE > ok 1..1 selftests: memfd: memfd_test [PASS] > selftests: memfd: run_fuse_test.sh > ======================================== > opening: ./mnt/memfd > fuse: DONE > ok 1..2 selftests: memfd: run_fuse_test.sh [PASS] > selftests: memfd: run_hugetlbfs_test.sh > ======================================== > Please run memfd with hugetlbfs test as root > not ok 1..3 selftests: memfd: run_hugetlbfs_test.sh [SKIP] > > Signed-off-by: Shuah Khan (Samsung OSG) Thanks for all your efforts in cleaning up selftests! Changes look fine to me. Reviewed-by: Mike Kravetz -- Mike Kravetz > --- > tools/testing/selftests/memfd/Makefile | 6 +++--- > .../testing/selftests/memfd/{run_tests.sh => run_hugetlbfs_test.sh} | 6 ------ > 2 files changed, 3 insertions(+), 9 deletions(-) > rename tools/testing/selftests/memfd/{run_tests.sh => run_hugetlbfs_test.sh} (95%) > > diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile > index 0862e6f47a38..53a848109f7b 100644 > --- a/tools/testing/selftests/memfd/Makefile > +++ b/tools/testing/selftests/memfd/Makefile > @@ -4,9 +4,9 @@ CFLAGS += -I../../../../include/uapi/ > CFLAGS += -I../../../../include/ > CFLAGS += -I../../../../usr/include/ > > -TEST_PROGS := run_tests.sh > -TEST_FILES := run_fuse_test.sh > -TEST_GEN_FILES := memfd_test fuse_mnt fuse_test > +TEST_GEN_PROGS := memfd_test > +TEST_PROGS := run_fuse_test.sh run_hugetlbfs_test.sh > +TEST_GEN_FILES := fuse_mnt fuse_test > > fuse_mnt.o: CFLAGS += $(shell pkg-config fuse --cflags) > > diff --git a/tools/testing/selftests/memfd/run_tests.sh b/tools/testing/selftests/memfd/run_hugetlbfs_test.sh > similarity index 95% > rename from tools/testing/selftests/memfd/run_tests.sh > rename to tools/testing/selftests/memfd/run_hugetlbfs_test.sh > index 2013f195e623..fb633eeb0290 100755 > --- a/tools/testing/selftests/memfd/run_tests.sh > +++ b/tools/testing/selftests/memfd/run_hugetlbfs_test.sh > @@ -4,12 +4,6 @@ > # Kselftest framework requirement - SKIP code is 4. > ksft_skip=4 > > -# > -# Normal tests requiring no special resources > -# > -./run_fuse_test.sh > -./memfd_test > - > # > # To test memfd_create with hugetlbfs, there needs to be hpages_test > # huge pages free. Attempt to allocate enough pages to test. >