From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdHOFTG (ORCPT ); Tue, 15 Aug 2017 01:19:06 -0400 Received: from mga14.intel.com ([192.55.52.115]:64386 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdHOFTF (ORCPT ); Tue, 15 Aug 2017 01:19:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,376,1498546800"; d="scan'208";a="139678675" To: Greg Kroah-Hartman Cc: Andreas Noever , Michael Jamet , Mika Westerberg , Lukas Wunner , Andy Shevchenko , linux-kernel@vger.kernel.org From: "Bernat, Yehezkel" Subject: [PATCH 1/3] thunderbolt: Remove superfluous check Message-ID: <29cf6caa-07a9-9c52-bd8c-6634749f99ca@intel.com> Date: Tue, 15 Aug 2017 08:19:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The key size is tested by hex2bin() already (as '\0' isn't an hex digit) Suggested-by: Andy Shevchenko Signed-off-by: Yehezkel Bernat --- drivers/thunderbolt/switch.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index e9391bb..69fde0b 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -808,9 +808,6 @@ static ssize_t key_store(struct device *dev, struct device_attribute *attr, u8 key[TB_SWITCH_KEY_SIZE]; ssize_t ret = count; - if (count < 64) - return -EINVAL; - if (hex2bin(key, buf, sizeof(key))) return -EINVAL; -- 2.7.4