From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A06BE7D0A2 for ; Thu, 21 Sep 2023 18:15:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjIUSPK (ORCPT ); Thu, 21 Sep 2023 14:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbjIUSO6 (ORCPT ); Thu, 21 Sep 2023 14:14:58 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3266A86E4D; Thu, 21 Sep 2023 10:38:14 -0700 (PDT) Received: from [192.168.1.23] (unknown [171.76.82.102]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: vignesh) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8AE526607310; Thu, 21 Sep 2023 15:01:44 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695304911; bh=3yyWULKsjhkzzVa9p1IJTEYYL2jBpe+zpuFtKjH7+oA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CBPEGhhBs5OUcu324ztmJ3Bu8KarI6VTr6bI9r1B88hlpXMeZjnm31An8Bio6kRY+ Y+O1+bnmOkyn2FnXfheLP7AHHE5GBRu2po/2TCKYriru/oB+Nojv7NmLASCw73KDwg AZZORMaV9fK4Pl2Izg/7ZpOQs6RLN9zkuxZ3sHCKA894PTaKjk0HB3Gtr6C5FNkwsl QEOqhXe3+SOu6EDutNnDpSVdwhS2p/r5iEi/eggAQ2copuyibLFH4qwooOSoy9+7FF nX5MmRECQ2VscvwQTGh2N/Ta7ihDbaK2xCMQt2Pmv/cHsIy2Mxw+rQv+nzU/ZjtBQA zNzzWT6eGtLMA== Message-ID: <29e47c3e-e10d-9268-93c7-133c959c5a82@collabora.com> Date: Thu, 21 Sep 2023 19:31:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode Content-Language: en-US To: Helen Koike , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, daniels@collabora.com, emma@anholt.net, robdclark@gmail.com, Dmitry Baryshkov , Maxime Ripard , David Heidelberg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230911161518.650726-1-vignesh.raman@collabora.com> From: Vignesh Raman In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi maintainers, On 12/09/23 22:39, Helen Koike wrote: > > > On 11/09/2023 13:15, Vignesh Raman wrote: >> Due to the presence of the fastboot micro cable in the CI farm, >> it causes the hardware to remain in gadget mode instead of host mode. >> So it doesn't find the network, which results in failure to mount root >> fs via NFS. > > Just a context for others, this was part of this patch series > https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com > >> >> Add an overlay dtso file that sets the dr_mode to host, allowing the >> USB controllers to work in host mode. With commit 15d16d6dadf6 >> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can >> be used to simplify the build of DTB overlays. It uses fdtoverlay to >> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb >> file can be used by drm-ci, mesa-ci. >> >> Suggested-by: Dmitry Baryshkov >> Suggested-by: Maxime Ripard >> Signed-off-by: Helen Koike >> Signed-off-by: David Heidelberg >> Signed-off-by: Vignesh Raman > > Acked-by: Helen Koike > > >> --- >>   arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++ >>   arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ >>   2 files changed, 12 insertions(+) >>   create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile >> b/arch/arm64/boot/dts/qcom/Makefile >> index 2cca20563a1d..99190a6ba6ff 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -1,5 +1,9 @@ >>   # SPDX-License-Identifier: GPL-2.0 >>   dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc.dtb >> + >> +apq8016-sbc-usb-host-dtbs    := apq8016-sbc.dtb >> apq8016-sbc-usb-host.dtbo >> + >> +dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc-usb-host.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc-d3-camera-mezzanine.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += apq8039-t2.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += >> apq8094-sony-xperia-kitakami-karin_windy.dtb >> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> new file mode 100644 >> index 000000000000..a82c26b7eae8 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso >> @@ -0,0 +1,8 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + >> +/dts-v1/; >> +/plugin/; >> + >> +&usb { >> +         dr_mode = "host"; >> +}; Please could you review this patch. Thanks. Regards, Vignesh