From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2 V2] mfd: constify properties in mfd_cell
Date: Sun, 9 Feb 2020 11:57:56 +0000 [thread overview]
Message-ID: <29e51a81900f4009ab173058bdf9ebde@intel.com> (raw)
In-Reply-To: <CAHp75Ve0PGO_s-nRk6zwk6QTcFi4Jm3yA-QZ7j7dxqVkYB=svA@mail.gmail.com>
>
> On Sat, Feb 8, 2020 at 8:44 PM Tomas Winkler <tomas.winkler@intel.com>
> wrote:
> >
> > Constify 'struct property_entry *properties' in mfd_cell It is always
> > passed around as a pointer const struct.
>
> I guess this should be second patch in the split and it's actually dependent to the
> first one (won't we get a compiler warning when we drop const qualifier during
> assignment?).
>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> >
> > V2: drop platform_device part
>
> Btw, when you prepare series, you may use -vX command line parameter,
> where X is a version number. The scripts will put v2 in each Subject line
> uniformly.
Right, just the second patch was a new one, so not sure I should mark it v2.
Thanks
Tomas
next prev parent reply other threads:[~2020-02-09 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 18:44 Tomas Winkler
2020-02-08 18:44 ` [PATCH 2/2] platform: constify properties in platform_device Tomas Winkler
2020-02-09 11:48 ` [PATCH 1/2 V2] mfd: constify properties in mfd_cell Andy Shevchenko
2020-02-09 11:57 ` Winkler, Tomas [this message]
2020-02-09 12:08 ` Andy Shevchenko
2020-02-09 12:10 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e51a81900f4009ab173058bdf9ebde@intel.com \
--to=tomas.winkler@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®