mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-pci@vger.kernel.org,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] PCI: rcar-host: Add static assertion to check !PCI_LOCKLESS_CONFIG
Date: Thu, 25 Sep 2025 15:51:32 +0200	[thread overview]
Message-ID: <29ee0c03-d1d9-44f9-bdde-5c336459b097@mailbox.org> (raw)
In-Reply-To: <mc5sglju5r7zubnnuzmnl6nf2t5xdz7x6rqbx26dnl5hzvnyhi@ydp767j7gqx5>

On 9/24/25 6:00 AM, Manivannan Sadhasivam wrote:
> On Wed, Sep 24, 2025 at 05:34:55AM +0200, Marek Vasut wrote:
>> Hello Manivannan,
>>
>> On 9/24/25 5:25 AM, Manivannan Sadhasivam wrote:
>>> On Wed, Sep 24, 2025 at 01:46:18AM +0200, Marek Vasut wrote:
>>>> This driver can not function correctly without PCIe subsystem level
>>>> config space access serialization. In case PCI_LOCKLESS_CONFIG is
>>>> ever enabled on ARM, complain loudly so the driver can be updated
>>>> accordingly.
>>>>
>>>
>>> This limitation applies to almost all host controller drivers except those used
>>> on Intel platforms like VMD and Hyper-V. So this would require adding the
>>> Kconfig dependency for all those, not just for RCAR.
>>
>> Correct.
>>
>>> We could also add the dependency to the arch Kconfig, but there is still a
>>> possibility that if the driver is used on a platform selecting
>>> PCI_LOCKLESS_CONFIG, it would be broken silently. So adding the dependency to
>>> the individual drivers that suffer from the limitation seems to be the right
>>> thing to do.
>>
>> Would you like me to send a few more patches which add !PCI_LOCKLESS_CONFIG
>> into per-driver Kconfig entries, at least for drivers where I am sure they
>> suffer from this currently hypothetical issue ...
>>
> 
> Sure.
> 
>>> Also, I'm not in favor of adding static_assert with Kconfig dependency in place.
>> ... and drop the static assert ?
>>
>> Then the drivers would at least be marked accordingly.
> 
> Yes. Better than what we have currently.
This is now done in

[PATCH] PCI: controller: Mark controllers which cannot do lockless 
config access with !PCI_LOCKLESS_CONFIG

I hope I got all of them.

      reply	other threads:[~2025-09-25 13:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 23:46 Marek Vasut
2025-09-24  3:25 ` Manivannan Sadhasivam
2025-09-24  3:34   ` Marek Vasut
2025-09-24  4:00     ` Manivannan Sadhasivam
2025-09-25 13:51       ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29ee0c03-d1d9-44f9-bdde-5c336459b097@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=bhelgaas@google.com \
    --cc=geert+renesas@glider.be \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mani@kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=robh@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®