From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384D9173 for ; Sat, 18 Jan 2025 17:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737222565; cv=none; b=mZawgDPe8gz/FGtDDA0zAnmG6lQe2nRm8wdXzVWFjyZyriRFRizlePHaNy9du4L9KrFfXyAf8agyT8JjQRg0iJndc8J/L5wzbL6LZBNxoDfRUA30k7L1IqYRBXIkqr3y8ttGHlsVt7mgSq8VueRoH4XOwAJzcRrDoEyGzxcZ5m4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737222565; c=relaxed/simple; bh=37E6Q5D0xVWNpTLVXS6hoqkzvLylDVXNvruX0Y2mLd0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LZ9UjwBqJlshURiC+Q1EPO0e38mVNga2P6mhLzaQAjj2XzuhcEvWKRRymogIpxQ1Fw3n3nxwJ5ocvquHxfEwfVs/6eATSAAjlSl81X6YsnT+7Dr5Iyt7RuUjMxOPugw0AVdLCJ1pQVlJ+eRtbs6jT9uftHXj/bMJdxhbpGNdrAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DZ0nKrwF; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DZ0nKrwF" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2ee8e8e29f6so4331702a91.0 for ; Sat, 18 Jan 2025 09:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737222563; x=1737827363; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=GU7FE91Y7VKzW3O3qn7y+qTA2pSkAbO4RD6j4nKnL+c=; b=DZ0nKrwFVJUF9kyz5qtAyy7sDlO+S2v6iREysf+wWEeNoRqDHYHh4TmGWCDrW4o+Jc h93+0cI0erWj77xo4+DpfDZaDu+xpuMFfohU22XR7ezJCIXoiqfC77QXpsSwC+hy7rwV OvulaZymmWPMPrDFN1kDp4T230XcbK51ktv64HSUa2DFHKYRXJ3fxL8BB4Stt9oteq+5 hzk9Z2CKwUnWB9Ln52PUEkgxxpD4GP4oA0KhyllJM9wt9YAEicSVysK3Ofqq9fSdS1An vs7Jm7D0LNUVceYiSiTvTA6dajnUpAUeEjS8Hu9u93NI3+lOFX5XnHUDA8B1FvbbKvdV IgJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737222563; x=1737827363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GU7FE91Y7VKzW3O3qn7y+qTA2pSkAbO4RD6j4nKnL+c=; b=lCC0rWBUfCsGRdNb97qFxlJO+zw30rtEv2I78Dsy9Vj9mvzqTHJOA2hUqAmG9gwKup dEwUhQkktjxA+cVl8Pij+sq0Dly+Gkqk6aVIFEMmIp1o4CatkHCsuM5nYErf8vAPRgRU fjB/UuqbPyKeYGEevLXxPK7IhmddhIDLmg5ljsInr0KVKCRlMgVhhP2PMmLNkMjb2OZk gPufiR/hcPOlFfrch/WKA5Ll2YdDSL1dB+LBNeMScMCIpHRUZlf8/3kPUnxPaSFYMQZB JBTS/64HSMUo5tCqPmU3E29qLWEtZ0tYWN0WzdqsIeqglWiryn0hoaDQRcnqAVpFH8lF dABA== X-Forwarded-Encrypted: i=1; AJvYcCWCKmas/SaZi0RRFscdPt9SjJnZKWFjRMGcOSN0pE9L+dUpJujVUzdABlnatGc8q53CVe5ahAN9T8S40CM=@vger.kernel.org X-Gm-Message-State: AOJu0YzdVzDy+VhxZOaZTFO2HCvaOMqHPOxkPTrtxOZfNvM0SH6uXKCM V28/neADk/+Sp17aeZAdVXtuSfOlYsxQWxC4Mrf5uFa/yG6YnyY2 X-Gm-Gg: ASbGncu+fU/xSQ62FbSH2ntvJ/X4Gf3WiD58yvZ4iamOVFQELqIBwuYwwRo3ilTTN6G PPu/YhgpIDXyeQpvZCNkDAiIgs0xgP4k3eg/QiatV26WEL1Lt9AKkPzoEDimbRQpJKq+u6+3fys BYbfKEB7USSGpeAS2M3PilVxEq43cyEK5vrB5TEHIx8iUZo5N8mRiOwfSv8koK/1RIjtTRa/i0E 2mNHJERaHO7pssywKjtFmX88JOY+Dw6pjdjBDr/VV0qMOyfqn4x+ZJ7LT+PI71uxug4gsBMWSxE H5xzPoQ= X-Google-Smtp-Source: AGHT+IHLAeXlO3hV4T4enIEVaprWMG6iSEGmCJjenAgTvawMCOMVSwu8lq2Sie7M0ZZb8hK7wtsTZA== X-Received: by 2002:a17:90a:c2ce:b0:2ee:a76a:820 with SMTP id 98e67ed59e1d1-2f782cbfa62mr11473228a91.18.1737222563329; Sat, 18 Jan 2025 09:49:23 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7762b37b1sm4358427a91.42.2025.01.18.09.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 09:49:22 -0800 (PST) Sender: Guenter Roeck Date: Sat, 18 Jan 2025 09:49:21 -0800 From: Guenter Roeck To: David Laight Cc: David Laight , Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi Subject: Re: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()) Message-ID: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250118170959.3aa56f4d@pumpkin> On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote: > On Sat, 18 Jan 2025 08:13:06 -0800 > Guenter Roeck wrote: > > > Hi, > > > > On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: > > > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity > > > check of the bounds in clamp(). > > > Gives better error coverage and one less expansion of the arguments. > > > > > > Signed-off-by: David Laight > > > > This patch triggers a build error when trying to build parisc:allmodconfig. > > See error message and bisect log below. > > > > I don't think there is anything wrong with the patch. The underlying > > problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which > > tries to build the affected file even though CONFIG_DRM_I915 is not > > enabled/supported on parisc. > > This has appeared before. > Any idea which inlined copy of scale() is causing the problem. > On the face of it they all look ok. > > If you can reproduce it maybe try commenting out some of the calls. > See diff below. All three changes are needed. No idea why the compiler would know that the values are invalid. Guenter --- diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c index fc1e517e074a..3b2c8bdfcf8d 100644 --- a/drivers/gpu/drm/i915/display/intel_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_backlight.c @@ -76,10 +76,14 @@ static u32 clamp_user_to_hw(struct intel_connector *connector, static u32 scale_hw_to_user(struct intel_connector *connector, u32 hw_level, u32 user_max) { +#if 0 struct intel_panel *panel = &connector->panel; return scale(hw_level, panel->backlight.min, panel->backlight.max, 0, user_max); +#else + return 0; +#endif } u32 intel_backlight_invert_pwm_level(struct intel_connector *connector, u32 val) @@ -119,8 +123,10 @@ u32 intel_backlight_level_to_pwm(struct intel_connector *connector, u32 val) drm_WARN_ON_ONCE(&i915->drm, panel->backlight.max == 0 || panel->backlight.pwm_level_max == 0); +#if 0 val = scale(val, panel->backlight.min, panel->backlight.max, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max); +#endif return intel_backlight_invert_pwm_level(connector, val); } @@ -138,8 +144,12 @@ u32 intel_backlight_level_from_pwm(struct intel_connector *connector, u32 val) intel_has_quirk(display, QUIRK_INVERT_BRIGHTNESS))) val = panel->backlight.pwm_level_max - (val - panel->backlight.pwm_level_min); +#if 0 return scale(val, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max, panel->backlight.min, panel->backlight.max); +#else + return 0; +#endif } static u32 lpt_get_backlight(struct intel_connector *connector, enum pipe unused)