From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B85C2BB85 for ; Fri, 10 Apr 2020 09:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A838206F7 for ; Fri, 10 Apr 2020 09:12:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aMd2+d5p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbgDJJME (ORCPT ); Fri, 10 Apr 2020 05:12:04 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:34538 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbgDJJMC (ORCPT ); Fri, 10 Apr 2020 05:12:02 -0400 Received: by mail-wm1-f68.google.com with SMTP id c195so4356452wme.1 for ; Fri, 10 Apr 2020 02:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=b2CpFz454BDdwSqjxr1G6oZhbHKRvHfmuEllgNAzRl4=; b=aMd2+d5pjt/YhcQB6BbQ7FOikvw1vYCKys3R3QEmkI6Kuar1sQNy7O47jG/TbMq9YQ QRWMyNFicIA8c1/4MRT5ymxHSswxEpO6OOeO1NL0pc3mw2knsEWtRIBLtPPiwVoDr7Nb 4LC4R/r9PlKF8ikSwBZ/dqHPfMJQIwYpT9wfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b2CpFz454BDdwSqjxr1G6oZhbHKRvHfmuEllgNAzRl4=; b=i6VzUfBr2ay2petHhHa2MAFY83tr45Dk/RobRjBpttP0g3x1vvT/U7+ViurBpkzNpb PCclEGFyeKiVK2pa3chLcnRkvI2lVNouGwTRNEH9x26PNg6PpmQXrRfrjOcG1O9z9hPN 6D2MJDkGdItsNIuW8YLvF3zCgxtKdWsBitsHiGa++ukGJ1HZEo1wEZ8s2up1NdN9H1Jp gLchD8MDOiX1zi6fEBxy7pT8ziZinDYm7aWfhWTIAO5UnDURr/Iwoi3PEJg6GTnY/HMT 8FuCrSc9P8DNxi4OflN6hJvUVVxUe3zGFdrZ547pd+f79hi43w+HIe9uaIUV1ncNzy71 H6yQ== X-Gm-Message-State: AGi0PuZ/+NV87S4kFN81hKvXSYNV5OQHidCBSO/S4bWXRF5hzYUtrlJu VBIh91k1arm5MNIyOgNMgQthe141GYDxPkrhnl3UXxtbcmuPDNHlLDQNq8O3eFzjnlCpVgeRNnk YsI1UpYve14o8JMF9ET0XwyL0C2ZdlfbbLLa0NwPmQYk4DcYkTIKmWOHnQlqIk33v5QdzR3G9PS sHmDnKfYcZOl1hMTZQ X-Google-Smtp-Source: APiQypLhWw+WB9Ta+aCTQgGcKmryDdYoaFIy26iFQ5zeat19uu9UDC16papfiNcRsQWb200xnLPn+g== X-Received: by 2002:a7b:cb45:: with SMTP id v5mr4107314wmj.17.1586509921001; Fri, 10 Apr 2020 02:12:01 -0700 (PDT) Received: from [192.168.178.129] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id j11sm2063686wrt.14.2020.04.10.02.11.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 02:12:00 -0700 (PDT) Subject: Re: [PATCH] brcmsmac: make brcms_c_set_mac() void To: Jason Yan , franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, kvalo@codeaurora.org, davem@davemloft.net, eduardoabinader@gmail.com, christophe.jaillet@wanadoo.fr, austindh.kim@gmail.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200410090817.26883-1-yanaijie@huawei.com> From: Arend Van Spriel Message-ID: <29f323a4-4749-0016-e5e5-6c17166876fc@broadcom.com> Date: Fri, 10 Apr 2020 11:11:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200410090817.26883-1-yanaijie@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/10/2020 11:08 AM, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:3773:5-8: > Unneeded variable: "err". Return "0" on line 3781 Acked-by: Arend van Spriel > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-)