From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F55C433EF for ; Wed, 8 Jun 2022 12:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239684AbiFHMuq (ORCPT ); Wed, 8 Jun 2022 08:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239701AbiFHMum (ORCPT ); Wed, 8 Jun 2022 08:50:42 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 93A4521D3C9 for ; Wed, 8 Jun 2022 05:50:38 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3ACBF1424; Wed, 8 Jun 2022 05:50:38 -0700 (PDT) Received: from [10.1.32.157] (e127744.cambridge.arm.com [10.1.32.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADFAF3F66F; Wed, 8 Jun 2022 05:50:35 -0700 (PDT) Subject: Re: [PATCH v2 2/2] coresight: etm4x: docs: Add documentation for 'ts_source' sysfs interface To: coresight@lists.linaro.org, mathieu.poirier@linaro.org, suzuki.poulose@arm.com Cc: james.clark@arm.com, leo.yan@linaro.org, mike.leach@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220503123537.1003035-1-german.gomez@arm.com> <20220503123537.1003035-2-german.gomez@arm.com> From: German Gomez Message-ID: <29f67a97-e711-c119-96ce-c4a1a281f855@arm.com> Date: Wed, 8 Jun 2022 13:50:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220503123537.1003035-2-german.gomez@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thanks for your comments and review in the previous submission (and sorry for not including a cover letter this time). Do you want me to hold on this change, or update the corresponding fields with new estimates? Thanks, German On 03/05/2022 13:35, German Gomez wrote: > Sync sysfs documentation pages to include the new ts_source (timestamp > source) interface. > > Signed-off-by: German Gomez > --- > v1: > - https://lore.kernel.org/all/20220429123100.268059-3-german.gomez@arm.com/ > v2: > - Update Data, KernelVersion, and Contact fields (Date is > tentative but likely). > --- > .../ABI/testing/sysfs-bus-coresight-devices-etm4x | 8 ++++++++ > .../trace/coresight/coresight-etm4x-reference.rst | 14 ++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-etm4x b/Documentation/ABI/testing/sysfs-bus-coresight-devices-etm4x > index 8e53a32f81505..520dd2e27eab3 100644 > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-etm4x > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-etm4x > @@ -516,3 +516,11 @@ Contact: Mathieu Poirier > Description: (Read) Returns the number of special conditional P1 right-hand keys > that the trace unit can use (0x194). The value is taken > directly from the HW. > + > +What: /sys/bus/coresight/devices/etm/ts_source > +Date: July 2022 > +KernelVersion: 5.19 > +Contact: Mathieu Poirier or Suzuki K Poulose > +Description: (Read) When FEAT_TRF is implemented, value of TRFCR_ELx.TS used for > + trace session. Otherwise -1 indicates an unknown time source. Check > + trcidr0.tssize to see if a global timestamp is available. > diff --git a/Documentation/trace/coresight/coresight-etm4x-reference.rst b/Documentation/trace/coresight/coresight-etm4x-reference.rst > index d25dfe86af9bf..f016c7c29429b 100644 > --- a/Documentation/trace/coresight/coresight-etm4x-reference.rst > +++ b/Documentation/trace/coresight/coresight-etm4x-reference.rst > @@ -71,6 +71,20 @@ the ‘TRC’ prefix. > > ---- > > +:File: ``ts_source`` (ro) > +:Trace Registers: None. > +:Notes: > + When FEAT_TRF is implemented, value of TRFCR_ELx.TS used for trace session. Otherwise -1 > + indicates an unknown time source. Check trcidr0.tssize to see if a global timestamp is > + available. > + > +:Example: > + ``$> cat ts_source`` > + > + ``$> 1`` > + > +---- > + > :File: ``addr_idx`` (rw) > :Trace Registers: None. > :Notes: