From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B39290DAC for ; Mon, 7 Jul 2025 09:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751881634; cv=none; b=WJYaJk/9U1KpwvpG9/ohWCX2jJ6MzUcQ8eLDWB9M8m5boDKj1//RKrN+uzCjDMRN04cRUTehvE3cRwfH1AfR9V9XWzRQVZc13EikN6vV7TglwqxctIuDfD1DdgwHeIYnyzCuVP9MoCws5t9yjS5iYibtzIPfbtAo5mzug+CJ7bE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751881634; c=relaxed/simple; bh=30/y4SG4wGEpss7IEM4IeQjEBYvCPPiFYxp6rK9lQ3Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bJ9aWOCDCOiIfb/yrNEvcOzoEwjd6tuAfeFk8f8wApobIxN7yr69rppQDzTShtToyWpnWpSrUQbEzKRykmFEHErbZfHfzewboUzlq2JhGdaGrGkd3oAVAu7mS6q4d5rMWnvuasn6+yVWdFiwG5GCsHI4vkiEdXN5Muc58N062FA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JkROgXYz; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JkROgXYz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751881631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4JOhzMO9hb/LtSXeWxWkjP1ZlyyrhtnOsL7SvQkX++k=; b=JkROgXYz5M889Nd2Ua+Yzi45wK0gftCehxpEUi+l+ZtsnAYVabqaJj58nRzmH00eiQ8l4l +maMNcpIrwFHzmZD7VskF0FZWm6gPlRQRdEEgtrJRqPQope3ufU4OmZy+Zrc8P6iVLncTs 4fFju4UWZf9vZH7QWsL+DZpjFSFj9uE= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-7syuedqyNHCwk-PKjoBmKA-1; Mon, 07 Jul 2025 05:47:06 -0400 X-MC-Unique: 7syuedqyNHCwk-PKjoBmKA-1 X-Mimecast-MFC-AGG-ID: 7syuedqyNHCwk-PKjoBmKA_1751881624 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 33767195395A; Mon, 7 Jul 2025 09:47:03 +0000 (UTC) Received: from [10.44.32.50] (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5B15B18002B6; Mon, 7 Jul 2025 09:46:55 +0000 (UTC) Message-ID: <29fb9fef-59d7-43f1-9c45-d6f5a4fe9818@redhat.com> Date: Mon, 7 Jul 2025 11:46:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v13 12/12] dpll: zl3073x: Add support to get/set frequency on pins To: Jiri Pirko Cc: netdev@vger.kernel.org, Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Jason Gunthorpe , Shannon Nelson , Dave Jiang , Jonathan Cameron , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Michal Schmidt , Petr Oros References: <20250704182202.1641943-1-ivecera@redhat.com> <20250704182202.1641943-13-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 07. 07. 25 10:32 dop., Jiri Pirko wrote: > Fri, Jul 04, 2025 at 08:22:02PM +0200, ivecera@redhat.com wrote: > > [...] > >> +static int >> +zl3073x_dpll_input_pin_frequency_set(const struct dpll_pin *dpll_pin, >> + void *pin_priv, >> + const struct dpll_device *dpll, >> + void *dpll_priv, u64 frequency, >> + struct netlink_ext_ack *extack) > > Unrelated to this patch, but ny idea why we don't implement > "FREQUENCY_CAN_CHANGE" capability. I think we are missing it. > Interesting question... from the driver API it is not necessary as the DPLL core can deduce FREQUENCY_CAN_CHANGE from existence of pin_frequency_set() callback and also if the pin reports empty or single item supported-frequencies list. Ivan