From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender-of-o55.zoho.eu (sender-of-o55.zoho.eu [136.143.169.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF3C3E557B for ; Wed, 18 Mar 2026 18:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.169.55 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773859389; cv=pass; b=KQZT8o+XA2hJG5/ZAy8oNl89aN/dR9OegjCNDuRGTghVg41A2Z2RZ2d/kEs+wVvlY3MGfVuGj/f5XrZY8qzI8IktF/3yF8rjAjTd/2dYoJcrqijnVIqsIH75tw9oEx3J/OYtvkvQ9QGd4/L5sYlu4Go2iGPPGYUqUkP6DxIXKn8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773859389; c=relaxed/simple; bh=J5KGt6Ne0FBkd9Tz3VuT2SneTLtZWlaIcpaCh5X9D4I=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=NzaObLbujIYzrrSgc4CgNCXuQpaejGOUUR+mB8sjgWNu7gAjuIQp7G0IMzGpPJlU4/d3fgvRzCIJ7gLrwl2e3aHyVTx8q+A/QilGKfjk4AdFvmfeH5bfmPOtITIVE/EvFxIL6grZ79gVMDcmTSrAHuRtOxQ9Pw/dY9aUhLQWL1I= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=objecting.org; spf=pass smtp.mailfrom=objecting.org; dkim=pass (1024-bit key) header.d=objecting.org header.i=objecting@objecting.org header.b=EZRD2C5/; arc=pass smtp.client-ip=136.143.169.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=objecting.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=objecting.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=objecting.org header.i=objecting@objecting.org header.b="EZRD2C5/" ARC-Seal: i=1; a=rsa-sha256; t=1773859377; cv=none; d=zohomail.eu; s=zohoarc; b=ZcWhDJ9V9GGwxCUcxgxc1OkQLC9jWMUCj2Fm1Pzu7PrPyysQeeGAQm/ft+xkIrn+CALBPEFiixKEJq3PFbTKcrQFQGE0hr5ll+fx8AbFUcqJmIvndwVd21O4Nk+4bUtzk/FFg+4y/yd3vJC7rFfQ7LrhfDX7NtdqkzOTyb9xx40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1773859377; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=J5KGt6Ne0FBkd9Tz3VuT2SneTLtZWlaIcpaCh5X9D4I=; b=Qmkk7006wfNOKluCqIGS6VINgcL/BG1/uYjlAJ+4LFk+DB5pWUAbvGGRRoEmX7nRYD98FBm7zdDo4O+68e7gfr9G+EgRgF/M6UxAxE24OHtKEJfMMozooELQNf6F6PaodgqgexdebpN+LYHCWeeaRGeL8HzU+Ng0yTJG8aEyZRQ= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=objecting.org; spf=pass smtp.mailfrom=objecting@objecting.org; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1773859377; s=zmail; d=objecting.org; i=objecting@objecting.org; h=Date:Date:From:From:To:To:CC:Subject:Subject:In-Reply-To:References:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=J5KGt6Ne0FBkd9Tz3VuT2SneTLtZWlaIcpaCh5X9D4I=; b=EZRD2C5/b7ScX74m/9lDHil625wyP4Ga5KCCUEd8j6OHYh8Bzr3sBrF8NbEPu7LT 98AKEHY8MChtsDXEoBoUYfPp9DcjzH21bgp71kMEklv8gYy1lA9jZ/ncbRBuiNfNWCM uCDIqGffao12bid1Ullae/dSHrAgbdjM4ttSM0sY= Received: by mx.zoho.eu with SMTPS id 1773859374630168.2590447370476; Wed, 18 Mar 2026 19:42:54 +0100 (CET) Date: Wed, 18 Mar 2026 18:42:55 +0000 From: Josh Law To: Andrew Morton CC: linux-kernel@vger.kernel.org, hlcj1234567@gmail.com, dhowells@redhat.com Subject: Re: [PATCH] lib/assoc_array: fix stale nr_leaves_on_tree after gc User-Agent: Thunderbird for Android In-Reply-To: <20260318113652.b9647a9000aaa42a014ace5d@linux-foundation.org> References: <20260318164959.85841-1-objecting@objecting.org> <20260318102319.0db807e1dc3e29fd1cde68b1@linux-foundation.org> <540EA561-7291-4AAF-8FAD-857793B811D9@objecting.org> <20260318113652.b9647a9000aaa42a014ace5d@linux-foundation.org> Message-ID: <2AC23AD7-C4D4-412A-9B6B-D74375E21D88@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External On 18 March 2026 18:36:52 GMT, Andrew Morton = wrote: >On Wed, 18 Mar 2026 17:29:10 +0000 Josh Law w= rote: > >> > >> >But assoc_array_apply_edit() alters array->nr_leaves_on_tree and now w= e >> >immediately overwrite that alteration? >>=20 >>=20 >> Hi Andrew, >>=20 >> It probably doesn't overwrite it in this specific case=2E >>=20 >>=20 >> In assoc_array_gc(), the edit script is zero-initialized, meaning edit-= >adjust_count_on is NULL=2E Because of this (and since array->root isn't NU= LL), assoc_array_apply_edit() safely skips the block that modifies nr_leave= s_on_tree=2E > >wordwrapping, please=2E > >> Since apply_edit() doesn't touch the count here, the explicit assignmen= t right after is necessary to record the newly calculated post-GC count=2E > >How about asking the author of this code? + CC: dhowells@redhat=2Ecom (file author) Sorry Andrew, my email client isn't the best (Thunderbird mobile), I'm awa= y from my laptop right now for a little bit=2E=2E V/R Josh Law