mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haakon Bugge <haakon.bugge@oracle.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: "horms@kernel.org" <horms@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	OFED mailing list <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3] rds: ib: Remove unused extern definition
Date: Fri, 5 Sep 2025 10:05:49 +0000	[thread overview]
Message-ID: <2AEDD90C-A0B6-4207-9C93-8C618AFB8EB7@oracle.com> (raw)
In-Reply-To: <4fa2f7bd9f9fd0d908e6a5ffee19bfd7dc6bde1b.camel@oracle.com>



> On 5 Sep 2025, at 00:43, Allison Henderson <allison.henderson@oracle.com> wrote:
> 
> On Thu, 2025-09-04 at 17:01 +0200, Håkon Bugge wrote:
>> In the old days, RDS used FMR (Fast Memory Registration) to register
>> IB MRs to be used by RDMA. A newer and better verbs based
>> registration/de-registration method called FRWR (Fast Registration
>> Work Request) was added to RDS by commit 1659185fb4d0 ("RDS: IB:
>> Support Fastreg MR (FRMR) memory registration mode") in 2016.
>> 
>> Detection and enablement of FRWR was done in commit 2cb2912d6563
>> ("RDS: IB: add Fastreg MR (FRMR) detection support"). But said commit
>> added an extern bool prefer_frmr, which was not used by said commit -
>> nor used by later commits. Hence, remove it.
>> 
>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
>> 
>> ---
> Hi Håkon,
> 
> Just one nit with the change log indentation here.  Version numbering is typically left-aligned, unless you meant to
> have a header of sorts to justify the level indentation.  Otherwise just bring the v2 -> v3: / v1 -> v2: lines flush
> left.
> 
> Content-wise this patch looks fine to me.  With the indent nit fixed, you can add my rvb:
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Hi Allison,


Will do. But, as you know, what comes after the "---" line gets stripped off when the patch is applied anyway.


Thxs, Håkon

> 
> Thank you!
> 
> Allison
> 
>> 
>> v2 -> v3:
>>      * As per Jakub's request, removed Cc: and Fixes: tags
>>      * Subject to net-next (instead of net)
>> 
>> v1 -> v2:
>>      * Added commit message
>>      * Added Cc: stable@vger.kernel.org
>> ---
>> net/rds/ib_mr.h | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h
>> index ea5e9aee4959e..5884de8c6f45b 100644
>> --- a/net/rds/ib_mr.h
>> +++ b/net/rds/ib_mr.h
>> @@ -108,7 +108,6 @@ struct rds_ib_mr_pool {
>> };
>> 
>> extern struct workqueue_struct *rds_ib_mr_wq;
>> -extern bool prefer_frmr;
>> 
>> struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_dev,
>>     int npages);


      reply	other threads:[~2025-09-05 10:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 15:01 Håkon Bugge
2025-09-04 22:43 ` Allison Henderson
2025-09-05 10:05   ` Haakon Bugge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2AEDD90C-A0B6-4207-9C93-8C618AFB8EB7@oracle.com \
    --to=haakon.bugge@oracle.com \
    --cc=allison.henderson@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®