From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbbJEWCK (ORCPT ); Mon, 5 Oct 2015 18:02:10 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:60494 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbbJEWCI convert rfc822-to-8bit (ORCPT ); Mon, 5 Oct 2015 18:02:08 -0400 From: John Youn To: Doug Anderson , John Youn CC: Yunzhi Li , "jwerner@chromium.org" , "huangtao@rock-chips.com" , "cf@rock-chips.com" , "hl@rock-chips.com" , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams() Thread-Topic: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams() Thread-Index: AQHQ2ZoF5pUJovT8502n5tIeDBFXnw== Date: Mon, 5 Oct 2015 22:02:06 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3875D2@US01WEMBX2.internal.synopsys.com> References: <1439890818-22138-1-git-send-email-lyz@rock-chips.com> <2B3535C5ECE8B5419E3ECBE30077290901DC335B43@us01wembx1.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.161.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/2015 1:50 PM, Doug Anderson wrote: > John, > > On Tue, Aug 18, 2015 at 5:19 PM, John Youn wrote: >> Hi Yunzhi, >> >> My concern is with the delays due to calling the dwc2_core_reset >> during probe. You could factor out the assertion of the core >> soft reset from the dwc2_core_reset and just use that before >> calling dwc2_get_hwparams(). >> >> You had previously addressed the lengthy probe time issue here: >> http://marc.info/?l=linux-usb&m=142357721304377 >> >> This reducing delays patch looks reasonable to me and I think it >> should get merged also. I'll do some testing with it later this >> week. > > Note: you can also avoid the extra reset during probe with something > like . I'm > happy to post that up if you want, though it depends on lyz's patch. > > ...in Chrome OS we've also just landed lyz's patch to reduce delays. > If there's any fallout I'll report on the list. > > -Doug > Yes, I appreciate if you could submit that. I'd like to merge lyz's reduce delays, lyz's bug fix for hwparams, and your fix for double reset. The gadget side will also need something similar which I can do if needed. Do you guys run gadget mode? Regards, John