From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdBHVlY convert rfc822-to-8bit (ORCPT ); Wed, 8 Feb 2017 16:41:24 -0500 Received: from mga11.intel.com ([192.55.52.93]:43489 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbdBHVlV (ORCPT ); Wed, 8 Feb 2017 16:41:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,348,1484035200"; d="scan'208";a="222988588" From: "Grandhi, Sainath" To: David Miller CC: "netdev@vger.kernel.org" , "mahesh@bandewar.net" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces Thread-Topic: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces Thread-Index: AQHSgW/+jTqCZTPBLUOMGQRa0+5eAaFfpI7g Date: Wed, 8 Feb 2017 21:41:19 +0000 Message-ID: <2C5142675EC1274EAB6230F72F8DC95F28CADC16@ORSMSX113.amr.corp.intel.com> References: <1486416975-14133-1-git-send-email-sainath.grandhi@intel.com> <20170207.132822.668043461053676694.davem@davemloft.net> In-Reply-To: <20170207.132822.668043461053676694.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzM5M2Q4NTMtM2RhZS00MmRhLWJlYWUtMmVlMWE0NWIyMzJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9WeWlIZFJLQXFYUWpcL2xrdnE0bmVsXC95TnFLYk5ZRytxUjRhTlwvbUJoaW89In0= x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, February 07, 2017 10:28 AM > To: Grandhi, Sainath > Cc: netdev@vger.kernel.org; mahesh@bandewar.net; linux- > kernel@vger.kernel.org > Subject: Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by > other virtual intefaces > > From: Sainath Grandhi > Date: Mon, 6 Feb 2017 13:36:08 -0800 > > > Tap character devices can be implemented on other virtual interfaces > > like ipvlan, similar to macvtap. Source code for tap functionality in > > macvtap can be re-used for this purpose. > > > > This patch series splits macvtap source into two modules, macvtap and tap. > > This patch series also includes a patch for implementing tap character > > device driver based on the IP-VLAN network interface, called ipvtap. > > > > These patches are tested on x86 platform. > > You're going to have to rework the module and Kconfig parts of this set of > changes. > > The user should not have to modify any existing Kconfig setting to get the > same set of modules which already exist today. > > Yet when I run "make oldconfig" after applying these changes it prompts me > for: > > TAP module support for virtual interfaces (TAP) [N/m/y/?] (NEW) > > And that's not really acceptable. I had MACVTAP set, I should still get the > infrastructure necessary to get that module built. > > If you want to do patch #6 you have to do it in a way that is transparent to > existing kernel configs. Please check the next version of patches. Modified Kconfig to make TAP as an user non-visible symbol. > > Thanks.