From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011052.outbound.protection.outlook.com [52.101.52.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3181D5160 for ; Fri, 27 Mar 2026 15:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.52 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774626559; cv=fail; b=YHUbrjAEsPlTkjZpZSvJCccQYsqqpO+AWczbbYTHkMFGihFTHEgTkDB4oddplfzkYXO0yPQ2P1kTDYx16gVMVlykU37ec2gX/CB1eF01CPEqD6VpEyi8HCemrXYh5mW1OHV8H08Tdupnx5wVPV9sj6AK6pGOZ1kXVlIonSkTGZ4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774626559; c=relaxed/simple; bh=BrfKrVKxuOmn6e53W1D6L4f4Bx0tnND9pqL1huUix+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MRWbBcutxZB5jN9O9ZYBFFnmfFV5MC0rScXIr1ODWXzEHftkZyYQgizFL3kyTJETP65kxeqeOA82L5xvG8ZhaLGldrQ4BvqnkVpgoj9sosssjs48UkcHMCSLsKT6babxIa7dNq9KgSXMmVgNfrPEZgSR+fK/Bhj/Mj7JTsqArvg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WV31kkBO; arc=fail smtp.client-ip=52.101.52.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WV31kkBO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g9PKr+El17wPgPBUzGQVeBidJQILY31edyjBlo0Gv4RBJPk7FXTcvVavE67Y8udI8mNL70Py9Es7iFezCunEsokYOx6XRNPKCG78plERxLPaTPO4xIGaQBVwDYJ9PM2Wj/S3eDEe8C6ZcUg3h3J9rjsgvJOoNL3VypZu8KR1USZPI1eCGm4jR1v80cWxP3uNBKIu4DhvKDtey6Ui69FKAzqGcbwujOAOsJ9VxmxTWPC1k0nOS25tdpLt+4Fj8XzTRtyHj75LhWrFJXvMMej9pcaOrYw72jNJ4/cAVnV9v5e4pIPWvS3HYgI3hzg/q2jpMYoqTRfUmP7siO06qjIo3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7uBtWh8WKLdfKi6qPuc2FrfBIHXaukUGz3vF+fvqFrw=; b=aD6hkNiXI4oJBr20473Qf5ZkhGGJj7HFxtR95NbMdgKpYLxf08sTb/7tyjOPzeP+YCIeNEaEoPsPoqQf883sGRO6xZR6bh1xMK1yN9LbJUXsrSO5GOXmXgLAZLv66nMDEEn4KTUROjEaiGRPgMRwgKsg850aQQyKXmAUCF2r2eCZJVTNQyvvMgofxbLoYTEClP6IeyN6t1x/+9u8Seezkyl4kxMrhe+QONbqErkDNZu/6CuIQcdHS/SQeUtiFx9jkx+EST9KdZc/HdnuCYCYI7Uk/o/EhfQIVEuSZp4Dc8H0g9KMRSu22NcBnk6a5O9PPnF2ZWM95Dqyp1Xwa/l1Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7uBtWh8WKLdfKi6qPuc2FrfBIHXaukUGz3vF+fvqFrw=; b=WV31kkBONM7ZVJBJuSZSfCdkpT+UA2cxwdygklOa+RmLCxWpk/ax5YCHnKgBlzWnBFd7Xoh4CVB0zixwKr6fiAqbC183sCJCAwFgbAuJd4J8qwbaXioz7Wi/mkIdxhz7ppUnCZGqFcIfpfo62x2CxmdoTp96ymp3XNargErknJMv35N7hnjq2V/XXP3RPTHW4JH/JqBHq5HcsEVGFgZSd3LK2l2OWLfzhK1jDhbIk4VV9vdDt/KeSOLhouOK9Avn0nGc0cQ0AICd+WtDt7IqxTGBuvMoOksUwoNMxi2RI8IDUBDoC/+O1THiw8A4ot+YHhsdGpb4WcQwj2O+D69u5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by PH0PR12MB8774.namprd12.prod.outlook.com (2603:10b6:510:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.10; Fri, 27 Mar 2026 15:49:14 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 15:49:14 +0000 From: Zi Yan To: Qi Zheng Cc: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ljs@kernel.org, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: Re: [PATCH v3 3/3] mm: memcontrol: correct the nr_pages parameter type of mem_cgroup_update_lru_size() Date: Fri, 27 Mar 2026 11:49:10 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <2EA22095-8C43-4BD6-AF4E-80AE125F478E@nvidia.com> In-Reply-To: References: Content-Type: text/plain X-ClientProxiedBy: BLAPR03CA0022.namprd03.prod.outlook.com (2603:10b6:208:32b::27) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|PH0PR12MB8774:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bb5ca5d-fb55-4472-e488-08de8c186560 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: G4hoHbWV1VPQuVxarb2gUwA+16/MfHMmc/wr4RWHqksYv72bLpOSmWXMVCTeShGlVEWs8pLb5MPzndqcS5eE4NkfNFt1bZYn20+aGtRHLho97DJHR0x9y3HWSfvVcbzv7VmD17BjJKOdm3LGWOmca6ZW/WcW36YZzqIwF2RjlaNN1a3EUkmw8pIl3R4xTXYyOkId6N5PzPEM02x7/vOpAdSGDrzoyUNF+hNqHUj92mH4Qezm5MyINQ8Gyhs+VybeZVpvcEG9+CJbIAwnx1lqiYwp4Mcgr9z9NSSRYZk2LKCgCt7KoBqNZ386VCY3D3d0T1+MrVTFVIG8YVd3GoR7motNrkiu9TYxDSY8G2uBdTe4H/MGTgIRtNYz4f5V5YPcoX9j69edjS4LhzOM1N6ZQ69OF9mbTq1W69mhTLQT/uX5d93h2aZC03G5/qbQ4E1yrsN5ES5t1aIdrzkMHFDCUh7MyoXVz6xWUbFPJHZ+NMZmX2pY8nXMCE1tsfGD2cItByNrk+SckzxmTWztd54CYwJRaRgC4cwWsVYKl+EuziiAtviCwh8M/4JsGk9gCb4DYAyxpxrH2pATKJNjCZk1XSehDymJGzRG7oYYtRR1GL6A3qWMOkMzB1YXVpgG4l9asyvSoHAswcySjpTu1Kgma7qPI6V89H1BhMoIFej56JhV7Pv8DmW2swc+Add+zU9foT8X6EkSRWNXg2aCrfuusUH8tvPKbYI9c1zqFfaZq54= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jr1ZQnQ35+azt1LC4gucOamGODGtvpvwWlNUOnwFIkWi1WtZu+VFf27i90YX?= =?us-ascii?Q?TQ0HPf9986FRF4ijviu+5N237XiMtCtm71s4pHRL4BGbyK+GNSTcQ9nQ9VvF?= =?us-ascii?Q?5s5RVwErjNQNLVpGsXjBuCWtmY7Y5fPM+dl3U6kYYUJ2OogdF740HNmPjZTu?= =?us-ascii?Q?7xTw5Rp/pA3oyYezfC5OdP/4qcFn4Bnr3XrHIaZBwkxvtbJxmuxg9Bxp4R/Y?= =?us-ascii?Q?HcxACppribIRGLSeOQBPU2Q7AKf5PXKUOjdp+7Nmrtf+w+O3KqUU5LQ9khQK?= =?us-ascii?Q?pyGQ077nUkJBuW21rnPiX9vcZkG9iY3cVezWayaYIA+ffNblbGn4cwcFl1Zq?= =?us-ascii?Q?8kuptChc/BA1vJw2ViCCYzhqlkheCGwegjfAQrLplx3uD5pRfpCdBTYhFI9D?= =?us-ascii?Q?5/Kjk3Ivlesc/NFczn1tAiwNZSwc6LjKU6skl8B1IiOZa/uk2F4NR8MWPhLJ?= =?us-ascii?Q?XpR9kj0nRRbOyqZ+Ygp6pwcFZ9IZaW1xBAuVTAPEBZJlnMa80hDdqE6IUiqM?= =?us-ascii?Q?DoIwvjGyDasJtA4fjShLuRTDzlI8TkFijozcRz0zqdFUwDfJk2PZxIUwrxv8?= =?us-ascii?Q?bEDWeHyqvGsxF/doUgHGOqPquXjb6JzXrUYnVa7Yl7VPp0VltQzEDK9kKpu6?= =?us-ascii?Q?x4GyuaMQlVuIQmkVUbYR3x1IAr7CnanVoKI4LHbYLto+8FvnzqmDEcTl9oui?= =?us-ascii?Q?FjBOWKQv9Eq3/nbUu/QECuyt9s8QeZjx1/61eFMtHShu7M0hcsZJv1brCeiW?= =?us-ascii?Q?kxpASG0VbXd79llepmIWLNQ6fhfexbFRC1F5LuOg46mthYANS60psgxNfC+D?= =?us-ascii?Q?ZmvxEcgtu5Uhop3W4+mLml1Gjw2TfisupFECEduuOESmJriTJo/V52RMJ7YV?= =?us-ascii?Q?ZILYcGVCqjcxGp9ba4zomTjySCe4ukpcFlAYwR1Z7GaX9BqYeG5YZKEKElkG?= =?us-ascii?Q?Eg3HMoPn1MUL+hc6yXlC03qbDN9AYUs3lcOyHzf6gmoLZiMNACApiXfIHiuc?= =?us-ascii?Q?9EKi4sqXdMaAx2ojBIBFpwnoxjSzKLeuaP8tOBnn/hNWAP8TPbP41aGQroqU?= =?us-ascii?Q?79SotOiio2hOzI+E7EzMHlsZfLs7WByhkso+q/Buzi2ktRfH7lcW3/p9EqSQ?= =?us-ascii?Q?UOSVg2tGSOPnL2GSbrYiVJJCjdadNrSZDl2odQPjNsqeTK4O372WWvB94ebQ?= =?us-ascii?Q?0pgAnkw2FqLVqdEAJkJlLJDNkNjb+Tr3fyrL25ogM88rauaUmGdLp5pSTVTf?= =?us-ascii?Q?HhEY5VI9gyQV1hNponXfR92nbxVlg0nxIITVs5kPVKFT+nFYHrF19fONyUO2?= =?us-ascii?Q?1U5k0lWVlCayR5Q+nPg1wDtTDhOs9TUBcDtDTyRQtKfi0MTeNtqnnFqR045p?= =?us-ascii?Q?YWa69mXsY0kcZaaGWgPC98JM/cUkmkl/TxOrOCNfyLrf3/GukpGoWLUlOVR6?= =?us-ascii?Q?aztKwypiyPJcm7BQcnZnJe68sxquTHFgATXxwescRpWjUVkGPar1Q3o+tfZc?= =?us-ascii?Q?eDQF6RjLCyxSEMDr+mxOmT0XgRbhq1Jwn65H24PUaRQxKE+eV9ZaWFtZdZjD?= =?us-ascii?Q?U1A9I1BvHAXpenDg8V9fLH4RNH/hAmuJoJqnTB08yVhDEwCqJ9E0FkgNFTgD?= =?us-ascii?Q?vsBP4Hv6GocQ2xULgpG5Lgc+V8LTvd1LGD+swYqdkkZIHeGaICGZSu8KMZEa?= =?us-ascii?Q?vyqzV9vKk1doM9JRuoPHr7yoV+/RaB0Jq1g8qSR6Qk4hG5mJ61byweO9ybcs?= =?us-ascii?Q?EflRe5i80g=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bb5ca5d-fb55-4472-e488-08de8c186560 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 15:49:14.2341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P2h0zznGirUxJiUhwCHvxEREfz1WEPgzIQAEgZdL+oqOfdi1Kyq03gT3Grf/eb9R X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8774 On 27 Mar 2026, at 6:16, Qi Zheng wrote: > From: Qi Zheng > > The nr_pages parameter of mem_cgroup_update_lru_size() represents a page > count. During the reparenting of LRU folios, the value passed to it can > potentially exceed the maximum value of a 32-bit integer. It should be > declared as long instead of int to match the types used in lruvec size > accounting and to prevent possible overflow. > > Update the parameter type to long to ensure correctness. > > Signed-off-by: Qi Zheng > --- > include/linux/memcontrol.h | 2 +- > mm/memcontrol.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Acked-by: Zi Yan Best Regards, Yan, Zi