From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41287C433E7 for ; Sat, 10 Oct 2020 22:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1304520795 for ; Sat, 10 Oct 2020 22:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388481AbgJJWyB convert rfc822-to-8bit (ORCPT ); Sat, 10 Oct 2020 18:54:01 -0400 Received: from aposti.net ([89.234.176.197]:47164 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731325AbgJJTKj (ORCPT ); Sat, 10 Oct 2020 15:10:39 -0400 Date: Sat, 10 Oct 2020 21:10:14 +0200 From: Paul Cercueil Subject: Re: [PATCH v4 0/3] pinctrl: Ingenic: Add support for SSI and I2S pins. To: Linus Walleij Cc: =?UTF-8?b?5ZGo55Cw5p2w?= , linux-kernel@vger.kernel.org, GPIO SUBSYSTEM , dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, yanfei.li@ingenic.com, sernia.zhou@foxmail.com, zhenwenjin@gmail.com Message-Id: <2L20IQ.FYURHZYQ6ZCT3@crapouillou.net> In-Reply-To: References: <20200913065836.12156-1-zhouyanjie@wanyeetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Zhou, The first patch is bogus. Half of the SSI pins are wrong (GPIO chip D/E start at 0x60/0x80 respectively). Sorry for not catching that before. -Paul Le mar. 29 sept. 2020 à 14:48, Linus Walleij a écrit : > On Sun, Sep 13, 2020 at 8:59 AM 周琰杰 (Zhou Yanjie) > wrote: > >> 1.Add SSI pins support for JZ4770 and JZ4780. >> 2.Correct the pullup and pulldown parameters of JZ4780. >> 3.Add I2S pins support for JZ4780, X1000, X1500, and X1830. >> >> v2->v3: >> 1.Add Paul Cercueil's Reviewed-by. >> 2.Fix bug about PE15's pull-up parameter. > > This v3 patch set applied! > > Thank you so much for your hard work! > > Yours, > Linus Walleij