Re: [PATCH 02/12] dt-bindings: display: Add ingenic,ipu.yaml

From: Paul Cercueil <paul@crapouillou.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	devicetree@vger.kernel.org, od@zcrc.me,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 02/12] dt-bindings: display: Add ingenic,ipu.yaml
Date: Sun, 17 May 2020 13:06:38 +0200	[thread overview]
Message-ID: <2V2HAQ.FED0YBJJAZ7D2@crapouillou.net> (raw)
In-Reply-To: <20200517061710.GB609600@ravnborg.org>

Hi Sam,

Le dim. 17 mai 2020 à 8:17, Sam Ravnborg <sam@ravnborg.org> a écrit :
> Hi Paul.
> On Sat, May 16, 2020 at 11:50:47PM +0200, Paul Cercueil wrote:
>>  Add documentation of the Device Tree bindings for the Image 
>> Processing
>>  Unit (IPU) found in most Ingenic SoCs.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> 
> For me it fails like this:

Oops. I missed the 'const:' in the item list. Will fix when I send a 
V2, and verify it this time.

Cheers,
-Paul

> /Documentation/devicetree/bindings/display/ingenic,ipu.yaml: 
> ignoring, error in schema: properties: compatible: oneOf: 1: items
> warning: no schema found in file: 
> Documentation/devicetree/bindings/display/ingenic,ipu.yaml
> make[2]: *** [Documentation/devicetree/bindings/Makefile:42: 
> Documentation/devicetree/bindings/processed-schema.yaml] Error 255
> make[2]: *** Waiting for unfinished jobs....
> Documentation/devicetree/bindings/display/ingenic,ipu.yaml: 
> properties:compatible:oneOf:1:items: ['ingenic,jz4770-ipu', 
> 'ingenic,jz4760-ipu'] is not valid under any of the given schemas 
> (Possible causes of the failure):
> 	Documentation/devicetree/bindings/display/ingenic,ipu.yaml: 
> properties:compatible:oneOf:1:items: ['ingenic,jz4770-ipu', 
> 'ingenic,jz4760-ipu'] is not of type 'object', 'boolean'
> 	Documentation/devicetree/bindings/display/ingenic,ipu.yaml: 
> properties:compatible:oneOf:1:items:0: 'ingenic,jz4770-ipu' is not of 
> type 'object', 'boolean'
> 	Documentation/devicetree/bindings/display/ingenic,ipu.yaml: 
> properties:compatible:oneOf:1:items:1: 'ingenic,jz4760-ipu' is not of 
> type 'object', 'boolean'
> 
> 
> 	Sam
> 
>>  ---
>>   .../bindings/display/ingenic,ipu.yaml         | 65 
>> +++++++++++++++++++
>>   1 file changed, 65 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/display/ingenic,ipu.yaml
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/display/ingenic,ipu.yaml 
>> b/Documentation/devicetree/bindings/display/ingenic,ipu.yaml
>>  new file mode 100644
>>  index 000000000000..22fe02ca866d
>>  --- /dev/null
>>  +++ b/Documentation/devicetree/bindings/display/ingenic,ipu.yaml
>>  @@ -0,0 +1,65 @@
>>  +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>  +%YAML 1.2
>>  +---
>>  +$id: http://devicetree.org/schemas/display/ingenic,ipu.yaml#
>>  +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>  +
>>  +title: Ingenic SoCs Image Processing Unit (IPU) devicetree bindings
>>  +
>>  +maintainers:
>>  +  - Paul Cercueil <paul@crapouillou.net>
>>  +
>>  +properties:
>>  +  compatible:
>>  +    oneOf:
>>  +      - enum:
>>  +        - ingenic,jz4725b-ipu
>>  +        - ingenic,jz4760-ipu
>>  +      - items:
>>  +        - ingenic,jz4770-ipu
>>  +        - ingenic,jz4760-ipu
>>  +
>>  +  reg:
>>  +    maxItems: 1
>>  +
>>  +  interrupts:
>>  +    maxItems: 1
>>  +
>>  +  clocks:
>>  +    maxItems: 1
>>  +
>>  +  clock-names:
>>  +    const: ipu
>>  +
>>  +patternProperties:
>>  +  "^ports?$":
>>  +    description: OF graph bindings (specified in 
>> bindings/graph.txt).
>>  +
>>  +required:
>>  +  - compatible
>>  +  - reg
>>  +  - interrupts
>>  +  - clocks
>>  +  - clock-names
>>  +
>>  +additionalProperties: false
>>  +
>>  +examples:
>>  +  - |
>>  +    #include <dt-bindings/clock/jz4770-cgu.h>
>>  +    ipu@13080000 {
>>  +      compatible = "ingenic,jz4770-ipu", "ingenic,jz4760-ipu";
>>  +      reg = <0x13080000 0x800>;
>>  +
>>  +      interrupt-parent = <&intc>;
>>  +      interrupts = <29>;
>>  +
>>  +      clocks = <&cgu JZ4770_CLK_IPU>;
>>  +      clock-names = "ipu";
>>  +
>>  +      port {
>>  +        ipu_ep: endpoint {
>>  +          remote-endpoint = <&lcdc_ep>;
>>  +        };
>>  +      };
>>  +    };
>>  --
>>  2.26.2
>> 
>>  _______________________________________________
>>  dri-devel mailing list
>>  dri-devel@lists.freedesktop.org
>>  https://lists.freedesktop.org/mailman/listinfo/dri-devel