From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC763D4114; Thu, 23 Apr 2026 04:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776917069; cv=none; b=uVXgBVkW9rOoPB6HJScdEu94vXZRoCLYrwZaF7Syrc0IYr1Mxs7aBhPWmC2eNSVBQgfPNy/B7oCBNWw/GMULjzafVbBepAPCx3CFusL1/iyadMWGGFx+AmwSYoO9hp+tyt/F4BJIinZoW09J/+z3y3JwcJuTJYhLCLseHb345fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776917069; c=relaxed/simple; bh=bzJBvGoGyO4TnHZ5apFVQzs3GCgFKmm9Wup3gNMX+ec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TlUSHRnL7encXhNXUfxMsGw/VzcHXxu1sI0nxB9ZtrD4JYWbVvPrLgf3V1FeMqH0AafGXruIqsIfKygmWOuHjH6hjh/fankAfIzoo54UHHQu4Ym1yQqT+1tFN9/bntylyOR2RFtrD/89xFt+o9zS5haVSCNbFsEsmG7/YgBCPwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kBXE0E2c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kBXE0E2c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FAC5C2BCB4; Thu, 23 Apr 2026 04:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776917069; bh=bzJBvGoGyO4TnHZ5apFVQzs3GCgFKmm9Wup3gNMX+ec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kBXE0E2ccU6hLStbQ1hi8YCScxAKPS0AjcS/vST+KZglJdttIsUu34fhYQXX03WKA EL/VWpNFh74xEsFiuZWJWGL1C3E8LK7ULuB3Sdu4gRrmGW3EDSnTKx3oHkFXKyoZd4 IEZ0cIlS1soOGWCXsTVp2ry0wR/2CVZK6qVJruZeQQ4Uz9CU4Prxg8s4xqeDj5SWYA /6R+3Fi3ZP/G8osKzKGWFYxhFR5/qdyqoKIEx0PhuUDjWl9iJvwyevog2jPeGsuJdy uVLFJ8Le/hA57JSTq9xT72RSLIblEuKc+ATLXbe9DooVU/noau+aVILc/GcZELxcuD WqZTsH4n8Dftw== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Peter Zijlstra , Joe Lawrence , Song Liu , Miroslav Benes , Petr Mladek Subject: [PATCH 12/48] objtool/klp: Fix cloning of zero-length section symbols Date: Wed, 22 Apr 2026 21:03:40 -0700 Message-ID: <2a02cb0d5de7a60f5ef135dac071c93f6303bd82.1776916871.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix NULL dereference when cloning a symbol from an empty section. sec->data is only populated for sections with non-zero size. Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for diffing object files") Signed-off-by: Josh Poimboeuf --- tools/objtool/klp-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c index 7f6f86117394..3303664a39d7 100644 --- a/tools/objtool/klp-diff.c +++ b/tools/objtool/klp-diff.c @@ -696,7 +696,7 @@ static struct symbol *__clone_symbol(struct elf *elf, struct symbol *patched_sym size_t size; /* bss doesn't have data */ - if (patched_sym->sec->data->d_buf) + if (patched_sym->sec->data && patched_sym->sec->data->d_buf) data = patched_sym->sec->data->d_buf + patched_sym->offset; if (is_sec_sym(patched_sym)) -- 2.53.0