From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83955C4332F for ; Thu, 14 Dec 2023 10:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443612AbjLNKXO (ORCPT ); Thu, 14 Dec 2023 05:23:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443555AbjLNKXN (ORCPT ); Thu, 14 Dec 2023 05:23:13 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D87CBAF; Thu, 14 Dec 2023 02:23:19 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BE8mErt009216; Thu, 14 Dec 2023 10:23:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=SWitZzAx3BEQ6/lWsAzh2+PnL1pOON7ercCfyknd650=; b=BF hyGsl/vQjc6ZyYA6stJYx9GsPGKSRABf3ijSoyX1FjHwMvMuSQ+BjbqassRruey+ fx+QSKxtK6G607OxPmI/RB4dSLPSaHDeylF8kca1D6z5BAbacmDjKZCt5xLwyVif Jf3sHU9nMIeeiU2+TyS9Nuzx0F7nIF0Xf+HjkzREGFLjTS2MOL3UjgY75+GtdP6A h/RVr3GgwTZBn+rrJp1hxu6pbzXRoNS9/VghtIXY2uiHWS2jGNT4e6YCvHpBc5By qhMIv12FgSXQubWmy8sw7Q1Cbs16R5z4EdB2Hqelx+ImTVP3Vd+83eL+al7Qv31b i4HmtL6j5A4Tc5KwOpig== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uysrprs7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 10:23:08 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BEAN7M2018879 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 10:23:07 GMT Received: from [10.216.56.9] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 14 Dec 2023 02:23:02 -0800 Message-ID: <2a064fde-0c90-4ef5-86bf-5dc9172149ab@quicinc.com> Date: Thu, 14 Dec 2023 15:52:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , References: <20231212133247.1366698-1-quic_omprsing@quicinc.com> <20231212133247.1366698-3-quic_omprsing@quicinc.com> <6b79c66d-7591-443b-92e5-beeff6c93ae4@quicinc.com> <5bc96a31-8869-483c-9427-1f4a90263874@linaro.org> Content-Language: en-US From: Om Prakash Singh In-Reply-To: <5bc96a31-8869-483c-9427-1f4a90263874@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: uYClRH4f3QwEZwTxQljvKzMPbJHviuq4 X-Proofpoint-GUID: uYClRH4f3QwEZwTxQljvKzMPbJHviuq4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 mlxscore=0 bulkscore=0 mlxlogscore=832 priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312140069 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2023 12:52 PM, Krzysztof Kozlowski wrote: > On 14/12/2023 06:41, Om Prakash Singh wrote: >> >> >> On 12/12/2023 8:32 PM, Krzysztof Kozlowski wrote: >>> On 12/12/2023 14:32, Om Prakash Singh wrote: >>>> Add the QCE and Crypto BAM DMA nodes. >>>> >>>> Signed-off-by: Om Prakash Singh >>>> --- >>>> >>>> Changes in V2: >>>> - Update DT node sequence as per register ascending order >>> >>> Hm, I don't see it... >>> >>>> - Fix DT node properties as per convention >>>> >>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>>> index 66f1eb83cca7..7b705df21f4e 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>>> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 { >>>> status = "disabled"; >>>> }; >>>> >>>> + cryptobam: dma-controller@1dc4000 { >>> >>> It still looks like not correctly ordered by unit address against other >>> nodes in the file. >>> >> >> Hi Krzysztof, >> Probably I am missing something basic here. I am trying to put entries >> addresses that are sorted wrt their current adjacent. >> >> And it looks fine to me. >> >> 1c0e000 (current exist) >> 1dc4000 (newly added) >> 1dfa000 (newly added) >> 1e40000 (current exist) > > Then why the diff shows: > @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 { > above your changes? my mistake! Local change was not added in updated patch. Submitting V3 > > Best regards, > Krzysztof >