mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zev Weiss <zev@bewilderbeest.net>
To: Conor Dooley <conor@kernel.org>
Cc: linux@roeck-us.net, Conor Dooley <conor.dooley@microchip.com>,
	Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	Peter Yin <peteryin.openbmc@gmail.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Naresh Solanki <naresh.solanki@9elements.com>
Subject: Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
Date: Fri, 23 Feb 2024 15:26:47 -0800	[thread overview]
Message-ID: <2a06f633-9dd2-4ef0-8cb8-901348ef404a@hatter.bewilderbeest.net> (raw)
In-Reply-To: <684ee927-2287-420b-aee5-f323e05ada47@hatter.bewilderbeest.net>

On Fri, Feb 23, 2024 at 03:16:28PM PST, Zev Weiss wrote:
>On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote:
>>From: Guenter Roeck <linux@roeck-us.net>
>>
>>If a chip only provides a single regulator, it should be named 'vout'
>>and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
>>that happen.
>>


>
>Given (AFAICT) the >lack of any combined dts & driver patches anywhere 
>in the kernel git history I guess maybe doing both atomically in a 
>single commit might not be considered kosher, but could it at least be 
>included in the same patch series?
>

Ah, except I realize now I neglected to pass '--full-diff' to 'git log' 
when checking that, and after fixing that I see there is in fact some 
precedent for commits changing device-trees and driver code together, so 
ideally that would be my preference here too.


Thanks,
Zev


  reply	other threads:[~2024-02-23 23:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
2024-02-23 16:21 ` [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators Conor Dooley
2024-02-24 11:13   ` Krzysztof Kozlowski
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
2024-02-24 11:14   ` Krzysztof Kozlowski
2024-02-24 18:13   ` Mark Brown
2025-04-10 16:15   ` Geert Uytterhoeven
2025-04-11 16:46     ` Conor Dooley
2025-04-11 16:57       ` Conor Dooley
2024-02-23 16:21 ` [PATCH v2 3/5] hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator Conor Dooley
2024-02-23 16:21 ` [PATCH v2 4/5] hwmon: (pmbus/lm25066) " Conor Dooley
2024-02-23 23:16   ` Zev Weiss
2024-02-23 23:26     ` Zev Weiss [this message]
2024-02-24  0:12       ` Guenter Roeck
2024-02-24 19:35     ` Conor Dooley
2024-02-23 16:21 ` [PATCH v2 5/5] hwmon: (pmbus/ir38064) " Conor Dooley
2024-02-24 17:22 ` [PATCH v2 0/5] PMBUS Regulator cleanups Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a06f633-9dd2-4ef0-8cb8-901348ef404a@hatter.bewilderbeest.net \
    --to=zev@bewilderbeest.net \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=naresh.solanki@9elements.com \
    --cc=patrick.rudolph@9elements.com \
    --cc=peteryin.openbmc@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®