From: "Christian König" <christian.koenig@amd.com>
To: Icenowy Zheng <uwu@icenowy.me>, Huang Rui <ray.huang@amd.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] drm/ttm: support device w/o coherency
Date: Mon, 1 Jul 2024 13:37:37 +0200 [thread overview]
Message-ID: <2a087cc4-1c17-4c00-839a-6736bdba2b73@amd.com> (raw)
In-Reply-To: <20240629052247.2653363-1-uwu@icenowy.me>
Am 29.06.24 um 07:22 schrieb Icenowy Zheng:
> This patchset tries to make TTM support devices w/o full DMA coherency
> capability (usually due to part of the link between the device and the
> CPU, esp. PCIe controller, do not have full coherency).
>
> The patchset itself looks quite straightforward, however I don't know
> why this isn't included in the kernel in years, so make it a RFC.
Well that's already supported your driver just need to request uncached
TT allocations.
Regards,
Christian.
>
> Tested on Rockchip RK3566, which has a PCIe controller w/o full
> coherency with an AMD OLAND GPU (R7 240). Mainly radeon driver is
> tested, but amdgpu driver is tried and at least OpenGL (glmark2) works.
> (The board used for testing is a Quartz64, which has a PCIe slot that
> can directly be seated with a PCIe graphics card)
>
> Icenowy Zheng (2):
> drm/ttm: save the device's DMA coherency status in ttm_device
> drm/ttm: downgrade cached to write_combined when snooping not
> available
>
> drivers/gpu/drm/ttm/ttm_bo_util.c | 4 ++++
> drivers/gpu/drm/ttm/ttm_device.c | 2 ++
> drivers/gpu/drm/ttm/ttm_tt.c | 4 ++++
> include/drm/ttm/ttm_caching.h | 3 ++-
> include/drm/ttm/ttm_device.h | 5 +++++
> 5 files changed, 17 insertions(+), 1 deletion(-)
>
prev parent reply other threads:[~2024-07-01 11:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 5:22 Icenowy Zheng
2024-06-29 5:22 ` [RFC PATCH 1/2] drm/ttm: save the device's DMA coherency status in ttm_device Icenowy Zheng
2024-06-29 5:22 ` [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available Icenowy Zheng
2024-06-29 19:57 ` Jiaxun Yang
2024-06-29 20:51 ` Icenowy Zheng
2024-07-01 11:40 ` Christian König
2024-07-01 11:52 ` Jiaxun Yang
2024-07-01 12:10 ` Christian König
2024-07-02 1:46 ` Icenowy Zheng
[not found] ` <ff1bf596-83cb-4b3e-a33a-621ac2c8171c@amd.com>
2024-07-02 9:06 ` Icenowy Zheng
[not found] ` <ae7085fd-3bca-4a4a-b465-5e4941011877@amd.com>
2024-07-02 10:01 ` Icenowy Zheng
2024-07-02 10:03 ` Jiaxun Yang
2024-07-03 8:52 ` PCIe coherency in spec (was: [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available) Jiaxun Yang
2024-07-03 21:08 ` Bjorn Helgaas
2024-07-04 2:00 ` Icenowy Zheng
2024-07-04 6:11 ` Christoph Hellwig
2024-07-04 6:40 ` Icenowy Zheng
2024-07-04 6:44 ` Christoph Hellwig
[not found] ` <4e958aa5-2a56-4754-b3dd-273da95f1d14@amd.com>
2024-07-02 9:36 ` [RFC PATCH 2/2] drm/ttm: downgrade cached to write_combined when snooping not available Icenowy Zheng
2024-06-30 6:52 ` Icenowy Zheng
2024-07-01 11:37 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a087cc4-1c17-4c00-839a-6736bdba2b73@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ray.huang@amd.com \
--cc=tzimmermann@suse.de \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®