From: Nathan Fontenot <nafonten@amd.com>
To: Perry Yuan <Perry.Yuan@amd.com>,
rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
Ray.Huang@amd.com, "Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Deepak.Sharma@amd.com, Mario.Limonciello@amd.com,
Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
Jinzhou.Su@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
Li.Meng@amd.com
Subject: Re: [PATCH 10/12] cpufreq: cpufreq: export cpufreq cpu release and acquire
Date: Thu, 7 Jul 2022 14:40:28 -0500 [thread overview]
Message-ID: <2a08a95d-6524-4f54-e6d2-76b43696ec0b@amd.com> (raw)
In-Reply-To: <20220707170103.216736-1-Perry.Yuan@amd.com>
On 7/7/22 12:01, Perry Yuan wrote:
> cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used internally by
> drivers/cpufreq/cpufreq.c currently.
> Export them so that other drivers such as the AMD P-state driver can use them as well.
>
Can you provide more information on why this is needed for the amd-pstate driver?
This patch exports the acquire/release functions but I don't see that the amd-pstate
driver is updated to use them.
-Nathan
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 73432360e6e9..4d3c83da29b7 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -262,6 +262,7 @@ void cpufreq_cpu_release(struct cpufreq_policy *policy)
>
> cpufreq_cpu_put(policy);
> }
> +EXPORT_SYMBOL_GPL(cpufreq_cpu_release);
>
> /**
> * cpufreq_cpu_acquire - Find policy for a CPU, mark it as busy and lock it.
> @@ -291,6 +292,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu)
>
> return policy;
> }
> +EXPORT_SYMBOL_GPL(cpufreq_cpu_acquire);
>
> /*********************************************************************
> * EXTERNALLY AFFECTING FREQUENCY CHANGES *
next prev parent reply other threads:[~2022-07-07 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 17:01 Perry Yuan
2022-07-07 19:40 ` Nathan Fontenot [this message]
2022-07-08 11:46 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a08a95d-6524-4f54-e6d2-76b43696ec0b@amd.com \
--to=nafonten@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome