From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbdCNNq5 (ORCPT ); Tue, 14 Mar 2017 09:46:57 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:46800 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbdCNNpf (ORCPT ); Tue, 14 Mar 2017 09:45:35 -0400 Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() To: Andy Shevchenko References: <20170308121943.29340-1-vigneshr@ti.com> CC: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List From: Vignesh R Message-ID: <2a0cf043-6e3f-6807-0794-d9d6f46b77f5@ti.com> Date: Tue, 14 Mar 2017 19:14:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: > On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R wrote: >> Passing "serial" as name during request_irq() results in all serial port >> irqs have same name. This does not help much to easily identify which >> irq belongs to which serial port instance. Therefore pass dev_name() >> during request_irq() so that better identifiable name is listed for >> serial ports in cat /proc/interrupts output. >> >> Output of cat /proc/interrupts >> Before this patch: >> 26: 689 0 GICv2 309 Edge serial >> After this patch: >> 26: 696 0 GICv2 309 Edge 2530c00.serial > > I don't know if it worth to mention that some (testing) tools may > depend on this name. I wonder how such tools will distinguish b/w different serial device instances. But, this change is making interrupt name more descriptive and maybe help test tools to distinguish irqs more easily > Besides that imagine what would be the name of PCI device here. > I would suggest adding ID if you need one in a form like > "serial%d", where ID may or may not be supplied by the actual 8250 drivers. > Are you suggesting to use serial_index() as ID? >> >> Signed-off-by: Vignesh R >> --- >> drivers/tty/serial/8250/8250_core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c >> index 76e03a7de9cc..f83b69f30987 100644 >> --- a/drivers/tty/serial/8250/8250_core.c >> +++ b/drivers/tty/serial/8250/8250_core.c >> @@ -218,7 +218,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up) >> spin_unlock_irq(&i->lock); >> irq_flags |= up->port.irqflags; >> ret = request_irq(up->port.irq, serial8250_interrupt, >> - irq_flags, "serial", i); >> + irq_flags, dev_name(up->port.dev), i); >> if (ret < 0) >> serial_do_unlink(i, up); >> } >> -- >> 2.11.0 >> > > > -- Regards Vignesh