From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7263AC593 for ; Mon, 5 May 2025 23:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487145; cv=none; b=hygg6NW6bgTLJi5tnCOJm3HD2GZ3gHQ22+HqH/bWNYik5FJwOrd+opesa5cT14tO51obU/v3jMvsP/hfYOE7RUm1PR5PTJfzJxPgOKvQPlijR6j3nrltyiiVADyirGA/gCfJ7ZFW94M9KGaqosLkBOj1jC+Ib40gXB9dVY7t4uI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487145; c=relaxed/simple; bh=szSy1DusHGWtdc5DBdNxGyYxoEy8zsXq36nE02dq3Dw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u3UbFYqW7oR45r3antBXg/Vuy9wmb1zW1mU6OLttm3VryPW4MJDpg7Ms7jN4HY5iJUpXqhd3ou1FHW3ZPlbbOs0YDD45atafINr3E1aB6Y0OJ1T4vfYMX4Yqpcdmnw+0flZThr0amg04m4fDjYeCvUwkXmznGNrIvXLxtPK/sPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oy84eHsy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oy84eHsy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 545M6MwX014054 for ; Mon, 5 May 2025 23:19:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= egliTNxrRWezR2u6nVEeNELYig/MxmMlQ01oFG+bL58=; b=oy84eHsyzw4cIS4t IbPIQBGACmEjACW5IsGawddvbVqI3FFn1seYPXHPptK9aK0cX84nidWwqwuonHVD yMve+Sosb0N8+Kfh2UNdHWK86ZhqRJj6oV9VqndrIEsP3x/GNOmkWWnAPMNzuH/M AL8M9xwo2k9cIRvghPBeEu7PVTNlMQxSfEwWTiNI2bCxvMvpwNuQPvNOvlYEyd/5 cGSBjVDx1pdRIbUsQdwNKnTg5KCFk/BNC2V88A+4EvHfFb1QPy/4vEBaG/gFNYjz Bjm5J54h3/Jf3v/q59zx4SzPLVXtb9msx0BQ+irCq8F0p31wiIOXflDDOiJR/kDL D9rRGA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46f5u404n9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 05 May 2025 23:19:00 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-22650077995so74141065ad.3 for ; Mon, 05 May 2025 16:19:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746487139; x=1747091939; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=egliTNxrRWezR2u6nVEeNELYig/MxmMlQ01oFG+bL58=; b=lIrvqoQj64JSHLLGnDEDqidiznwaKqpcoeGbhisulvAqATIOgPVYpjrfc2RFFr+Mvm rm6lhuRnQJM+8+EFZOHOh33DZ52scRFTGvuhqkxsDCkCs4udc/0nk80uEwMZ42S6X6tf 43QxmFru6iHXj0aAshzz50eOdrvCiyzJ2KzcHQn4U4eC3nuMFc8iBd1MFOjQOvU+dCxa PnkfB39Do8s8pMLnDd2s5mslEsB7aLnrJhHsYihhfr1zaB8oPpCWyveVfF5vYLImpwmb c2TOyp6awOLLg/NU9aXwpXdJ1Yg6s9V/skezXPPfzhWFi3ptzKHPCjTnIb334GfQV4Fa Mzjg== X-Forwarded-Encrypted: i=1; AJvYcCVPeLUY3Kb1Xi96buy4v0yQG9SuxvrN3tKUz5vm05ENOXk/jQkp0ogSpsmUE3Xk2SSa6DJSQGfTlHWYKG8=@vger.kernel.org X-Gm-Message-State: AOJu0YxdLhqFE2bNFqHN+n9XJGW8/ND0nBONvvjAJ8UKKuMeWN4Io+Xc dF3uLyfbnYsALKGQ8TNFxDJiWbLmntv6c51ETUTCS5gfp4ZqLvKBLZi+jtoqYCRfwvALrmIPGUm iyLw17yVxRl4IkyvQmOAQnjYh4LIEJwWX7DbnmYOscF2ycmPJOQ5qHoRqWoAUIQ== X-Gm-Gg: ASbGncsEhwLhKorKe5gcqd8xnYO25bgdfh7rI6cBqFpWepSAeJUJpyV49+lxedlDJg3 Kje4qIhvzSjU4o0qJ0bJlukA3EXvK113ZaAROGE0Ekx+yQuWqfw4E6/H0l70bmMUQa75N98JAiX KPC3tbKPIrgMBbjzEMuy4ANH94XL33PDVN1nFqPphx9yBBQEvR35TPxCUXhYRRGorQUSkc+eEMM Q3NXnWECoXxxl11GVxmoOuHzBcHAoTbjy7q3WtMZgVfqvU4Oaqg2MR+avnGdv9Sdvf+VpQNsr00 sTzShTEaAX3u4vfzaedE0+rJQjPPvUVqP0dPoi26SxG3p3GjW737RqK3s4+sKmob4++KQqktV2j LxH+nilyQow== X-Received: by 2002:a17:903:11ce:b0:215:a179:14ca with SMTP id d9443c01a7336-22e35fa48edmr11374005ad.2.1746487138857; Mon, 05 May 2025 16:18:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdqr8QmR5hHl03YHuIdiZ5XDPvQLzJ8NRfBgcXvm6h4rkFqPZiU9iHtAyIKS5UBK5d6Ay3DA== X-Received: by 2002:a17:903:11ce:b0:215:a179:14ca with SMTP id d9443c01a7336-22e35fa48edmr11373785ad.2.1746487138404; Mon, 05 May 2025 16:18:58 -0700 (PDT) Received: from [192.168.0.74] (n1-41-240-65.bla22.nsw.optusnet.com.au. [1.41.240.65]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e1521fb3esm60612335ad.121.2025.05.05.16.18.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 16:18:57 -0700 (PDT) Message-ID: <2a0df02a-1657-4b59-8f31-791a8aff523e@oss.qualcomm.com> Date: Tue, 6 May 2025 09:18:49 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/11] firmware: qcom: scm: remove unused arguments to the shm_brige To: Kuldeep Singh , Jens Wiklander , Sumit Garg , Bjorn Andersson , Konrad Dybcio , Bartosz Golaszewski , Apurupa Pattapu , Kees Cook , "Gustavo A. R. Silva" , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org References: <20250428-qcom-tee-using-tee-ss-without-mem-obj-v4-0-6a143640a6cb@oss.qualcomm.com> <20250428-qcom-tee-using-tee-ss-without-mem-obj-v4-6-6a143640a6cb@oss.qualcomm.com> <246da659-2add-4ccf-b914-f737fb93f3f2@quicinc.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: <246da659-2add-4ccf-b914-f737fb93f3f2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KcfSsRYD c=1 sm=1 tr=0 ts=68194765 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=hi51d+lTLNy/RbqRqnOomQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=S5yCOARCkap2nlZrFcEA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: icHRjR5XAS4mR6tVl3ypcU1CHzNtorzw X-Proofpoint-ORIG-GUID: icHRjR5XAS4mR6tVl3ypcU1CHzNtorzw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA1MDIyMCBTYWx0ZWRfX1TQvXU4KTyJT ygBtHG1jP5hh4p5IXmXeI841FLu9tanEMCRFZMIP91CD5MyjXBT+EaaJSIvBWJZ/xFqZy2CSQDF gMeIq4WrBEdKNoNYE/GNfeRFiCtgWGL31//S2ROvixDJrb0+Cq0p1lTEr8mTJm4DEg4wZm9OCh1 zIXwPJrArgLEZlr96JTxJJBlaRvQUzTmoHwfeyBz+tlz11caA8JyYgNjoM2eBnYfFp1u+peraqJ N5aTWjjpwzPtvYA9KsMMViQLrVzlIRK2dbBHew+u5oHXH2w1pLTfVQeeLgB4rra/FzDFZRHTVzk 2cJJMFeiQjrqNfDtUW590maEfaXN10EifqJf7I3V81Cb0iRQZi4NAH1lHdY5XODhfUtbWUYlErV EoYQYMDoBWIZI3VaAGymglVCHOOgM6Ps8xb5BDrBIolBttRIV0nFwxAqa3YzpYonzfKAuOTB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-05_10,2025-05-05_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505050220 On 5/5/2025 8:58 PM, Kuldeep Singh wrote: > > > On 4/29/2025 11:36 AM, Amirreza Zarrabi wrote: >> shm_bridge create/delete functions always use the scm device. >> There is no need to pass it as an argument. >> >> Signed-off-by: Amirreza Zarrabi > > > There are 2 type of APIs exposed by tzmem driver for pool creation. > devm_qcom_tzmem_pool_new and qcom_tzmem_pool_new. > > Device managed pool is created with devm_qcom_tzmem_pool_new but > currently qcom_scm is using it's own dev to create/delete bridge which > is problamatic here. > > https://elixir.bootlin.com/linux/v6.14.5/source/drivers/firmware/qcom/qcom_scm.c#L1653 > > If pool is device managed, same dev should be used in qcom_scm to > create/delete bridge rather than using qcom_scm dev. > The dev passed as an argument to function should be used instead of > __scm->dev. > https://elixir.bootlin.com/linux/v6.14.5/source/drivers/firmware/qcom/qcom_scm.c#L1634 > > To summarize, I believe correct solution should be to pass corresponding > dev to bridge create/delete APIs instead of always assuming to be > qcom_scm dev for devm_qcom_tzmem_pool_new scenarios. > For qcom_tzmem_pool_new, qcom_scm/qcom_tzmem_dev can be used. > > Bartosz/Amirreza, please share your thoughts as well. > It is not true. Why should shmbridge need to have access to random devices, while the resources are obtained from the scm device, if any? - Amir