From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45A13E558E for ; Mon, 30 Mar 2026 22:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774910992; cv=none; b=kktZyxLskBDQChp/JUv1igMhrZpdl9JpjVOj74LhgKlzW/MsjYC1l5xO729X+LnO9HSh+2R0H7FHHu9VwG1Xy1eVVWCROaKFXgg+yDOI2Y1eQyLPX4HlsoYMUNxisLTETiGZoMauc78Kvt9QFBYmqfmihhPWkjvpJdKlxifBUts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774910992; c=relaxed/simple; bh=7anFCZoYp9WMJApmuJm70DGhnai/wq766/BxAZxtR5M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lvchiWWoj5K2FcEpJKLr95bPyOz5CQT5GlSg9Ez5+7oH+oob21Y+Pkg7o3AoPIJoNoNbADZ5XWVg+ERXeGTY2apwpGSCr8fLpwePwPlqvi7j0fhpbgj0gaKMcztSosgzLMmSxYXvadMJgyjCMYzmMEISK90O+MhWlMEvItn6VN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XlVazujy; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XlVazujy" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-38c6bd590f5so5250971fa.3 for ; Mon, 30 Mar 2026 15:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774910985; x=1775515785; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=fkzA/8PwZigV8lDDqxn0XcVr3NG0HEYSbBhRSeKkujA=; b=XlVazujyKcR0C8KyRR2oyhxlw51MIpvS2V96BIh+KIfYvgfxoe1W7l9xv4O2f83rIV Kmle/eVgmKFldbE3CB18Ipz9tb2/yns7uBYL/hYrkPVmJ0h3qqvAc/wbHDkKneuvKSWm 7iuIGFXs1Lr9Hjb3UHgP1WHl5HsLQUP8Zf4TOOHxx60qdQW9RTPVVDSAZkFWZ9xlUck1 cF7HM2OtMrTkfpCw+e0QGkGwtwiNJ7weaYlpNjdgKieLbauzeN/D02xHHxtHZHASfmzc Zift4rk7MMTWqI9r+l/6Rw0/i9MXYgqJl9uVLYVeMrJLuFeHURbk/hfuYxlVRbH7aixL fJHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774910985; x=1775515785; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fkzA/8PwZigV8lDDqxn0XcVr3NG0HEYSbBhRSeKkujA=; b=rM7lqWj67oeHEUiRxBWpLPR0H6wv44ycyKxskNEHIa4BBH39nRFm4mYPi/WmDOOfw2 vm8f7kGCtKus1vkhvdLEcKTh8G7u94G0bCINx9jIGxbaDGbfrB9oQ62aydu7iDcEXIes QXfDzNjGA7jKn6ISq88HUacivz2L2CmXEo4lz62XVeEnkyhtruRSMqcu2NOn8NXVc71O q3jYPtHlukA0Uj1VFOIIKkOSGV5I1XOESSKlL3LdSWMwWgzn8LC6lmcXYt0gQHjMo9qG rL2lsYklySgkLvuLvp9Mg0/MqTj73Z7dCD6bUNOUofx17bAYlzsdsPxSdpOHOkNaQ6iZ oROg== X-Forwarded-Encrypted: i=1; AJvYcCUA+XbiFGeD7GgjWZZ6rMCo8Eqit5uco2jSJma3sz6QIQUWzyRvMXX+dNmgxgmHkIxJCguxpYXnH9mBkK8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw14tYacvukV1u9DnG7VyK5yh1HMQpnSqAb+kI7aDe0jRfBzNWY YVGHg7Ovo7/ns8hyLTiQT691p66lj3IqRadm9E++L+WY6F7RUBSjmtxmy6pnnR1qgM8= X-Gm-Gg: ATEYQzyxxLl3NDH71Pfz0ttNKoNXBApyGrrDA2wUXyoFV4HMBQo3Wj4R7WOF5q8gBbQ rS9qvbVnYSOmGBhC+oV8gRDDI6sEER7E/pfEn5waQfYgqANMR9lsX3lPC5Sp6sx3MZWgXGmhn0Y r6NPkIZHazp2ooTqNe8+9h9lB2hZ1GyMXAVK/xQ6uOysMBXA3NTk8q6zrCNZrqQfbN75OXC9K2i b2XW5mKMWpfXrQbuXAEh6n8BKMPeEPy0fYqRcc+nVnehlRLA4ySN1ICqUx6YLNz1lE22rfhpIRB F+buCmg3Z3iL9H44pGuJI+eKi6eVYDe7t1G5UcUM64t9/nNgjw2LgaVCUGCFeuQ5cRk1tM2w+Go vlt1YxekAe7HKBbCiTMnS+Du5VRplvCmBeJewZ76VDgiLQWqnrNdNd7Mv9bHsxfIOchdBariSj4 iPLN4kp6IL7OyeD0tGt+g7JfAUsd09/QEFsD50RoGjMCwoDIA6OK9TAJPTsKNymLqnBoQW9SS8x ifWoTVYu3fZJWyq X-Received: by 2002:a05:6512:1252:b0:5a2:a23b:c439 with SMTP id 2adb3069b0e04-5a2ab92cc5fmr2237800e87.6.1774910985110; Mon, 30 Mar 2026 15:49:45 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2b13f426csm1959250e87.7.2026.03.30.15.49.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 15:49:44 -0700 (PDT) Message-ID: <2a108976-374a-46e1-968d-7befa4369a74@linaro.org> Date: Tue, 31 Mar 2026 01:49:43 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/3] Add CAMSS support for SM6350 To: Luca Weiss Cc: Bryan O'Donoghue , Konrad Dybcio , Bryan O'Donoghue , Conor Dooley , Robert Foss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson References: <20260216-sm6350-camss-v4-0-b9df35f87edb@fairphone.com> From: Vladimir Zapolskiy In-Reply-To: <20260216-sm6350-camss-v4-0-b9df35f87edb@fairphone.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 2/16/26 10:54, Luca Weiss wrote: > Add bindings, driver and dts to support the Camera Subsystem on the > SM6350 SoC. > > These patches were tested on a Fairphone 4 smartphone with WIP sensor > drivers (Sony IMX576 and IMX582), the camera pipeline works properly as > far as I can tell. > > Though when stopping the camera stream, the following clock warning > appears in dmesg. But it does not interfere with any functionality, > starting and stopping the stream works and debugcc is showing 426.4 MHz > while the clock is on, and 'off' while it's off. > > Any suggestion how to fix this, is appreciated. I've looked at CAMCC recently, and I do notice that SM6350 CAMCC does not set '.use_rpm = true' flag for whatever reason. If you find a free minute, can you test the change below?.. ----8<---- diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-sm6350.c index 7df12c1311c6..ba880e4edcaf 100644 --- a/drivers/clk/qcom/camcc-sm6350.c +++ b/drivers/clk/qcom/camcc-sm6350.c @@ -1880,6 +1880,7 @@ static const struct qcom_cc_desc camcc_sm6350_desc = { .num_clks = ARRAY_SIZE(camcc_sm6350_clocks), .gdscs = camcc_sm6350_gdscs, .num_gdscs = ARRAY_SIZE(camcc_sm6350_gdscs), + .use_rpm = true, }; static const struct of_device_id camcc_sm6350_match_table[] = { ----8<---- This change could be considered to be included in any case, I believe. > [ 5738.590980] ------------[ cut here ]------------ > [ 5738.591009] gcc_camera_axi_clk status stuck at 'on' > [ 5738.591049] WARNING: CPU: 0 PID: 6918 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x170/0x190 > [ 5738.591081] Modules linked in: > [ 5738.591099] CPU: 0 UID: 10000 PID: 6918 Comm: plasma-camera Tainted: G W 6.17.0-00057-ge6b67db49622 #71 NONE > [ 5738.591118] Tainted: [W]=WARN > [ 5738.591126] Hardware name: Fairphone 4 (DT) > [ 5738.591136] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 5738.591150] pc : clk_branch_toggle+0x170/0x190 > [ 5738.591164] lr : clk_branch_toggle+0x170/0x190 > [ 5738.591177] sp : ffff800086ed3980 > [ 5738.591184] x29: ffff800086ed3990 x28: 0000000000000001 x27: ffff800086ed3cd8 > [ 5738.591208] x26: 0000000000000000 x25: ffffda14fcfbd250 x24: 0000000000000000 > [ 5738.591230] x23: 0000000000000000 x22: ffffda14fc38bce0 x21: 0000000000000000 > [ 5738.591252] x20: ffffda14fd33e618 x19: 0000000000000000 x18: 00000000000064c8 > [ 5738.591274] x17: 0000000000000000 x16: 00001ae003667e9e x15: ffffda14fd2a07b0 > [ 5738.591295] x14: 0000000000000000 x13: 6f27207461206b63 x12: 7574732073757461 > [ 5738.591317] x11: 0000000000000058 x10: 0000000000000018 x9 : ffffda14fd2a0838 > [ 5738.591338] x8 : 0000000000057fa8 x7 : 0000000000000a16 x6 : ffffda14fd2f8838 > [ 5738.591360] x5 : ffff0001f6f59788 x4 : 0000000000000a15 x3 : ffff25ecf9d7e000 > [ 5738.591381] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff0000baf5c100 > [ 5738.591403] Call trace: > [ 5738.591412] clk_branch_toggle+0x170/0x190 (P) > [ 5738.591429] clk_branch2_disable+0x1c/0x30 > [ 5738.591445] clk_core_disable+0x5c/0xb4 > [ 5738.591462] clk_disable+0x38/0x60 > [ 5738.591478] camss_disable_clocks+0x44/0x78 > [ 5738.591496] vfe_put+0x7c/0xc0 > [ 5738.591512] vfe_set_power+0x40/0x50 > [ 5738.591528] pipeline_pm_power_one+0x14c/0x150 > [ 5738.591546] pipeline_pm_power+0x74/0xf4 > [ 5738.591561] v4l2_pipeline_pm_use+0x54/0x9c > [ 5738.591577] v4l2_pipeline_pm_put+0x14/0x40 > [ 5738.591592] video_unprepare_streaming+0x18/0x24 > [ 5738.591608] __vb2_queue_cancel+0x4c/0x314 > [ 5738.591626] vb2_core_streamoff+0x24/0xc8 > [ 5738.591643] vb2_ioctl_streamoff+0x58/0x98 > [ 5738.591657] v4l_streamoff+0x24/0x30 > [ 5738.591672] __video_do_ioctl+0x430/0x4a8 > [ 5738.591689] video_usercopy+0x2ac/0x680 > [ 5738.591705] video_ioctl2+0x18/0x40 > [ 5738.591720] v4l2_ioctl+0x40/0x60 > [ 5738.591734] __arm64_sys_ioctl+0x90/0xf0 > [ 5738.591750] invoke_syscall.constprop.0+0x40/0xf0 > [ 5738.591769] el0_svc_common.constprop.0+0x38/0xd8 > [ 5738.591785] do_el0_svc+0x1c/0x28 > [ 5738.591801] el0_svc+0x34/0xe8 > [ 5738.591820] el0t_64_sync_handler+0xa0/0xe4 > [ 5738.591838] el0t_64_sync+0x198/0x19c > [ 5738.591854] ---[ end trace 0000000000000000 ]--- > > Signed-off-by: Luca Weiss > --- > Changes in v4: > - Update power-domain-names order (Krzysztof) > - Make hex numbers lower case in init seq (David) > - Pick up tags > - Link to v3: https://lore.kernel.org/r/20260213-sm6350-camss-v3-0-30a845b0b7cc@fairphone.com Should find some time myself to issue RBs, sorry for the delay. > Changes in v3: > - Update dt-bindings to include everything related to camss > - Update regulator names > - Remove slow_ahb_src > - Link to v2: https://lore.kernel.org/r/20251114-sm6350-camss-v2-0-d1ff67da33b6@fairphone.com > > Changes in v2: > - Remove prefix from interconnect-names > - Move 'top' power-domain to the top of list > - Update regulator supply names > - Link to v1: https://lore.kernel.org/r/20251024-sm6350-camss-v1-0-63d626638add@fairphone.com > > --- > Luca Weiss (3): > dt-bindings: media: camss: Add qcom,sm6350-camss > media: qcom: camss: Add SM6350 support > arm64: dts: qcom: sm6350: Add CAMSS node > > .../bindings/media/qcom,sm6350-camss.yaml | 471 +++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm6350.dtsi | 233 ++++++++++ > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 125 ++++++ > drivers/media/platform/qcom/camss/camss-vfe.c | 2 + > drivers/media/platform/qcom/camss/camss.c | 261 ++++++++++++ > drivers/media/platform/qcom/camss/camss.h | 1 + > 6 files changed, 1093 insertions(+) > --- > base-commit: 3daf23347bb5f4a375d0101ed29c97ce1a99721b > change-id: 20251024-sm6350-camss-9c404bf9cfdd > > Best regards, -- Best wishes, Vladimir